| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAC=S1nhEiWmFkVMVGqg97TqXQqLhP0KZkQvq+F=k_hS_Jg297Q@mail.gmail.com>
Date: Thu, 31 Jul 2025 11:10:15 +0800
From: Fei Shao <fshao@...omium.org>
To: Laura Nao <laura.nao@...labora.com>
Cc: srini@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
rafael@...nel.org, daniel.lezcano@...aro.org, rui.zhang@...el.com,
lukasz.luba@....com, matthias.bgg@...il.com,
angelogioacchino.delregno@...labora.com, andrew-ct.chen@...iatek.com,
kernel@...labora.com, nfraprado@...labora.com, arnd@...db.de,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, u.kleine-koenig@...libre.com,
linux-arm-kernel@...ts.infradead.org, wenst@...omium.org,
linux-mediatek@...ts.infradead.org, bchihi@...libre.com,
colin.i.king@...il.com, lala.lin@...iatek.com
Subject: Re: [PATCH v2 2/9] thermal/drivers/mediatek/lvts: Make number of
calibration offsets configurable
On Wed, Jul 30, 2025 at 11:30 PM Laura Nao <laura.nao@...labora.com> wrote:
>
> MT8196/MT6991 use 2-byte eFuse calibration data, whereas other SoCs
> supported by the driver rely on 3 bytes. Make the number of calibration
> bytes per sensor configurable, enabling support for SoCs with varying
> calibration formats.
>
> Signed-off-by: Laura Nao <laura.nao@...labora.com>
Reviewed-by: Fei Shao <fshao@...omium.org>
> ---
> drivers/thermal/mediatek/lvts_thermal.c | 32 +++++++++++++++++--------
> 1 file changed, 22 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
> index f4d1e66d7db9..05aa8895ccce 100644
> --- a/drivers/thermal/mediatek/lvts_thermal.c
> +++ b/drivers/thermal/mediatek/lvts_thermal.c
> @@ -96,12 +96,14 @@
>
> #define LVTS_MINIMUM_THRESHOLD 20000
>
> +#define LVTS_MAX_CAL_OFFSETS 3
> +
> static int golden_temp = LVTS_GOLDEN_TEMP_DEFAULT;
> static int golden_temp_offset;
>
> struct lvts_sensor_data {
> int dt_id;
> - u8 cal_offsets[3];
> + u8 cal_offsets[LVTS_MAX_CAL_OFFSETS];
> };
>
> struct lvts_ctrl_data {
> @@ -127,6 +129,7 @@ struct lvts_data {
> const struct lvts_ctrl_data *lvts_ctrl;
> const u32 *conn_cmd;
> const u32 *init_cmd;
> + int num_cal_offsets;
> int num_lvts_ctrl;
> int num_conn_cmd;
> int num_init_cmd;
> @@ -711,7 +714,7 @@ static int lvts_calibration_init(struct device *dev, struct lvts_ctrl *lvts_ctrl
> u8 *efuse_calibration,
> size_t calib_len)
> {
> - int i;
> + int i, j;
> u32 gt;
>
> /* A zero value for gt means that device has invalid efuse data */
> @@ -720,17 +723,18 @@ static int lvts_calibration_init(struct device *dev, struct lvts_ctrl *lvts_ctrl
> lvts_for_each_valid_sensor(i, lvts_ctrl_data) {
> const struct lvts_sensor_data *sensor =
> &lvts_ctrl_data->lvts_sensor[i];
> + u32 calib = 0;
>
> - if (sensor->cal_offsets[0] >= calib_len ||
> - sensor->cal_offsets[1] >= calib_len ||
> - sensor->cal_offsets[2] >= calib_len)
> - return -EINVAL;
> + for (j = 0; j < lvts_ctrl->lvts_data->num_cal_offsets; j++) {
> + u8 offset = sensor->cal_offsets[j];
> +
> + if (offset >= calib_len)
> + return -EINVAL;
> + calib |= efuse_calibration[offset] << (8 * j);
> + }
>
> if (gt) {
> - lvts_ctrl->calibration[i] =
> - (efuse_calibration[sensor->cal_offsets[0]] << 0) +
> - (efuse_calibration[sensor->cal_offsets[1]] << 8) +
> - (efuse_calibration[sensor->cal_offsets[2]] << 16);
> + lvts_ctrl->calibration[i] = calib;
> } else if (lvts_ctrl->lvts_data->def_calibration) {
> lvts_ctrl->calibration[i] = lvts_ctrl->lvts_data->def_calibration;
> } else {
> @@ -1763,6 +1767,7 @@ static const struct lvts_data mt7988_lvts_ap_data = {
> .temp_factor = LVTS_COEFF_A_MT7988,
> .temp_offset = LVTS_COEFF_B_MT7988,
> .gt_calib_bit_offset = 24,
> + .num_cal_offsets = 3,
> };
>
> static const struct lvts_data mt8186_lvts_data = {
> @@ -1776,6 +1781,7 @@ static const struct lvts_data mt8186_lvts_data = {
> .temp_offset = LVTS_COEFF_B_MT7988,
> .gt_calib_bit_offset = 24,
> .def_calibration = 19000,
> + .num_cal_offsets = 3,
> };
>
> static const struct lvts_data mt8188_lvts_mcu_data = {
> @@ -1789,6 +1795,7 @@ static const struct lvts_data mt8188_lvts_mcu_data = {
> .temp_offset = LVTS_COEFF_B_MT8195,
> .gt_calib_bit_offset = 20,
> .def_calibration = 35000,
> + .num_cal_offsets = 3,
> };
>
> static const struct lvts_data mt8188_lvts_ap_data = {
> @@ -1802,6 +1809,7 @@ static const struct lvts_data mt8188_lvts_ap_data = {
> .temp_offset = LVTS_COEFF_B_MT8195,
> .gt_calib_bit_offset = 20,
> .def_calibration = 35000,
> + .num_cal_offsets = 3,
> };
>
> static const struct lvts_data mt8192_lvts_mcu_data = {
> @@ -1815,6 +1823,7 @@ static const struct lvts_data mt8192_lvts_mcu_data = {
> .temp_offset = LVTS_COEFF_B_MT8195,
> .gt_calib_bit_offset = 24,
> .def_calibration = 35000,
> + .num_cal_offsets = 3,
> };
>
> static const struct lvts_data mt8192_lvts_ap_data = {
> @@ -1828,6 +1837,7 @@ static const struct lvts_data mt8192_lvts_ap_data = {
> .temp_offset = LVTS_COEFF_B_MT8195,
> .gt_calib_bit_offset = 24,
> .def_calibration = 35000,
> + .num_cal_offsets = 3,
> };
>
> static const struct lvts_data mt8195_lvts_mcu_data = {
> @@ -1841,6 +1851,7 @@ static const struct lvts_data mt8195_lvts_mcu_data = {
> .temp_offset = LVTS_COEFF_B_MT8195,
> .gt_calib_bit_offset = 24,
> .def_calibration = 35000,
> + .num_cal_offsets = 3,
> };
>
> static const struct lvts_data mt8195_lvts_ap_data = {
> @@ -1854,6 +1865,7 @@ static const struct lvts_data mt8195_lvts_ap_data = {
> .temp_offset = LVTS_COEFF_B_MT8195,
> .gt_calib_bit_offset = 24,
> .def_calibration = 35000,
> + .num_cal_offsets = 3,
> };
>
> static const struct of_device_id lvts_of_match[] = {
> --
> 2.39.5
>
>
Powered by blists - more mailing lists