[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <51648c0f-dd30-4a07-83c0-533a57c29e63@kernel.org>
Date: Wed, 30 Jul 2025 09:46:02 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: zhangsenchuan@...incomputing.com, gregkh@...uxfoundation.org,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, Thinh.Nguyen@...opsys.com, p.zabel@...gutronix.de
Cc: ningyu@...incomputing.com, linmin@...incomputing.com,
yangwei1@...incomputing.com, pinkesh.vaghela@...fochips.com
Subject: Re: [PATCH v2 1/2] dt-bindings: usb: Add Eswin EIC7700 USB controller
On 30/07/2025 09:40, zhangsenchuan@...incomputing.com wrote:
> +
> +examples:
> + - |
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
This wasn't here. Drop.
> +
> + usb {
> + compatible = "eswin,eic7700-dwc3";
> + clocks = <&fixed_factor_u_clk_1m_div24>,
> + <&gate_clk_hsp_aclk>,
> + <&gate_clk_hsp_cfgclk>;
> + clock-names = "suspend","aclk", "cfg";
> + eswin,hsp-sp-csr = <&hsp_sp_csr 0x800 0x808 0x83c 0x840>;
> + resets = <&reset 84>;
> + reset-names = "vaux";
> + ranges;
Same comment: follow DTS coding style. Where should ranges or reg be placed?
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + usb@...80000 {
> + compatible = "snps,dwc3";
> + reg = <0x0 0x50480000 0x0 0x10000>;
Nothing improved and you did not respond to the feedback.
Best regards,
Krzysztof
Powered by blists - more mailing lists