linux-kernel - Re: Re: [PATCH v2 1/2] dt-bindings: usb: Add Eswin EIC7700 USB controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f9a715d.3bb7.1985ef71b54.Coremail.zhangsenchuan@eswincomputing.com>
Date: Thu, 31 Jul 2025 13:31:49 +0800 (GMT+08:00)
From: zhangsenchuan <zhangsenchuan@...incomputing.com>
To: "Krzysztof Kozlowski" <krzk@...nel.org>
Cc: gregkh@...uxfoundation.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	Thinh.Nguyen@...opsys.com, p.zabel@...gutronix.de,
	ningyu@...incomputing.com, linmin@...incomputing.com,
	yangwei1@...incomputing.com, pinkesh.vaghela@...fochips.com
Subject: Re: Re: [PATCH v2 1/2] dt-bindings: usb: Add Eswin EIC7700 USB
 controller




> -----原始邮件-----
> 发件人: "Krzysztof Kozlowski" <krzk@...nel.org>
> 发送时间:2025-07-30 15:46:02 (星期三)
> 收件人: zhangsenchuan@...incomputing.com, gregkh@...uxfoundation.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, Thinh.Nguyen@...opsys.com, p.zabel@...gutronix.de
> 抄送: ningyu@...incomputing.com, linmin@...incomputing.com, yangwei1@...incomputing.com, pinkesh.vaghela@...fochips.com
> 主题: Re: [PATCH v2 1/2] dt-bindings: usb: Add Eswin EIC7700 USB controller
> 
> On 30/07/2025 09:40, zhangsenchuan@...incomputing.com wrote:
> > +
> > +examples:
> > +  - |
> > +    soc {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> 
> This wasn't here. Drop.
> 
> > +
> > +        usb {
> > +            compatible = "eswin,eic7700-dwc3";
> > +            clocks = <&fixed_factor_u_clk_1m_div24>,
> > +                     <&gate_clk_hsp_aclk>,
> > +                     <&gate_clk_hsp_cfgclk>;
> > +            clock-names = "suspend","aclk", "cfg";
> > +            eswin,hsp-sp-csr = <&hsp_sp_csr 0x800 0x808 0x83c 0x840>;
> > +            resets = <&reset 84>;
> > +            reset-names = "vaux";
> > +            ranges;
> 
> Same comment: follow DTS coding style. Where should ranges or reg be placed?

According to the "dts-coding-style.html", the order should be like below, is this correct?

compatible = "eswin,eic7700-dwc3";
ranges;
#address-cells = <1>;
#size-cells = <1>;

> 
> > +            #address-cells = <2>;
> > +            #size-cells = <2>;
> > +
> > +            usb@...80000 {
> > +                compatible = "snps,dwc3";
> > +                reg = <0x0 0x50480000 0x0 0x10000>;
> 
> Nothing improved and you did not respond to the feedback.

I'm very sorry that I haven't given you any feedback here. I'm not quite clear about what you mean by feedback.
In v1 patch, you mentioned "Fold the child node into the parent"，could you please tell me what's the exact
meaning of this comment?
> 
> 
> Best regards,
> Senchuan Zhang