linux-kernel - Re: [PATCH v2 1/2] dt-bindings: usb: Add Eswin EIC7700 USB controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17f9763b-7ae5-4429-ab16-058eddf9c79c@kernel.org>
Date: Thu, 31 Jul 2025 08:11:29 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: zhangsenchuan <zhangsenchuan@...incomputing.com>
Cc: gregkh@...uxfoundation.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, linux-usb@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 Thinh.Nguyen@...opsys.com, p.zabel@...gutronix.de,
 ningyu@...incomputing.com, linmin@...incomputing.com,
 yangwei1@...incomputing.com, pinkesh.vaghela@...fochips.com
Subject: Re: [PATCH v2 1/2] dt-bindings: usb: Add Eswin EIC7700 USB controller

On 31/07/2025 07:31, zhangsenchuan wrote:
>>
>>> +            #address-cells = <2>;
>>> +            #size-cells = <2>;
>>> +
>>> +            usb@...80000 {
>>> +                compatible = "snps,dwc3";
>>> +                reg = <0x0 0x50480000 0x0 0x10000>;
>>
>> Nothing improved and you did not respond to the feedback.
> 
> I'm very sorry that I haven't given you any feedback here. I'm not quite clear about what you mean by feedback.
> In v1 patch, you mentioned "Fold the child node into the parent"，could you please tell me what's the exact
> meaning of this comment?
It means you should not have separate child for dwc3, but only one node
in total.

Best regards,
Krzysztof