[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <80020ba1-cd00-4ce7-962f-04218559582c@sirena.org.uk>
Date: Wed, 30 Jul 2025 13:04:52 +0100
From: Mark Brown <broonie@...nel.org>
To: ew kim <ew.kim@...sung.com>
Cc: s.nawrocki@...sung.com, robh@...nel.org, krzk+dt@...nel.org,
lgirdwood@...il.com, tiwai@...e.com, perex@...ex.cz,
conor+dt@...nel.org, alim.akhtar@...sung.com,
linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/9] ASoC: samsung: Add generic ABOX management driver
On Mon, Jul 21, 2025 at 11:30:44AM +0900, ew kim wrote:
> This driver implements the *generic* (fixed) part of the ABOX management
> stack for Samsung Automotive SoCs. It does not directly control hardware
> but provides common interfaces and state needed by SoC-specific
> (variable) drivers.
> The abox generic driver manages child drivers and provides an interface
> that bridges the fixed and variable parts, connecting the two modules.
I think for such an unusual design we need a much clearer description of
what this is trying to do and why it's not following normal kernel
patterns. I can't tell what the services this generic code is providing
are, nor why it's done this way.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists