linux-kernel - Re: [PATCH V3 2/3] mmc: sdhci-pci-gli: GL9763e: Rename the gli_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7ba16c8-e6ab-4ca2-bf7e-8719c469f59a@intel.com>
Date: Wed, 30 Jul 2025 18:54:02 +0300
From: Adrian Hunter <adrian.hunter@...el.com>
To: Victor Shih <victorshihgli@...il.com>, <ulf.hansson@...aro.org>
CC: <linux-mmc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<benchuanggli@...il.com>, <ben.chuang@...esyslogic.com.tw>,
	<HL.Liu@...esyslogic.com.tw>, Victor Shih <victor.shih@...esyslogic.com.tw>,
	<stable@...r.kernel.org>
Subject: Re: [PATCH V3 2/3] mmc: sdhci-pci-gli: GL9763e: Rename the
 gli_set_gl9763e() for consistency

On 29/07/2025 09:58, Victor Shih wrote:
> From: Victor Shih <victor.shih@...esyslogic.com.tw>
> 

Also needs to explain in the commit message, why it has a stable tag, say:

	In preparation to fix replay timer timeout, rename the gli_set_gl9763e() to
	gl9763e_hw_setting() for consistency.

With that:

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> Rename the gli_set_gl9763e() to gl9763e_hw_setting() for consistency.
> 
> Signed-off-by: Victor Shih <victor.shih@...esyslogic.com.tw>
> Fixes: 1ae1d2d6e555 ("mmc: sdhci-pci-gli: Add Genesys Logic GL9763E support")
> Cc: stable@...r.kernel.org
> ---
>  drivers/mmc/host/sdhci-pci-gli.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> index f678c91f8d3e..436f0460222f 100644
> --- a/drivers/mmc/host/sdhci-pci-gli.c
> +++ b/drivers/mmc/host/sdhci-pci-gli.c
> @@ -1753,7 +1753,7 @@ static int gl9763e_add_host(struct sdhci_pci_slot *slot)
>  	return ret;
>  }
>  
> -static void gli_set_gl9763e(struct sdhci_pci_slot *slot)
> +static void gl9763e_hw_setting(struct sdhci_pci_slot *slot)
>  {
>  	struct pci_dev *pdev = slot->chip->pdev;
>  	u32 value;
> @@ -1925,7 +1925,7 @@ static int gli_probe_slot_gl9763e(struct sdhci_pci_slot *slot)
>  	gli_pcie_enable_msi(slot);
>  	host->mmc_host_ops.hs400_enhanced_strobe =
>  					gl9763e_hs400_enhanced_strobe;
> -	gli_set_gl9763e(slot);
> +	gl9763e_hw_setting(slot);
>  	sdhci_enable_v4_mode(host);
>  
>  	return 0;