[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <eab85cb3-7185-4474-9428-8699fbe4a8e5@kernel.org>
Date: Thu, 31 Jul 2025 08:45:45 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ram Kumar Dwivedi <quic_rdwivedi@...cinc.com>, mani@...nel.org,
alim.akhtar@...sung.com, avri.altman@....com, bvanassche@....org,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
andersson@...nel.org, konradybcio@...nel.org, agross@...nel.org
Cc: linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V1 2/3] arm64: dts: qcom: sm8650: Enable MCQ support for
UFS controller
On 30/07/2025 10:22, Ram Kumar Dwivedi wrote:
> Enable Multi-Circular Queue (MCQ) support for the UFS host controller
> on the Qualcomm SM8650 platform by updating the device tree node. This
> includes adding new register regions and specifying the MSI parent
> required for MCQ operation.
>
> MCQ is a modern queuing model for UFS that improves performance and
> scalability by allowing multiple hardware queues.
>
> Changes:
> - Add reg entries for mcq_sqd and mcq_vs regions.
> - Define reg-names for the new regions.
> - Specify msi-parent for interrupt routing.
>
> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@...cinc.com>
> ---
> arch/arm64/boot/dts/qcom/sm8650.dtsi | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> index e14d3d778b71..5d164fe511ba 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> @@ -3982,7 +3982,12 @@ ufs_mem_phy: phy@...0000 {
>
> ufs_mem_hc: ufshc@...4000 {
> compatible = "qcom,sm8650-ufshc", "qcom,ufshc", "jedec,ufs-2.0";
> - reg = <0 0x01d84000 0 0x3000>;
> + reg = <0 0x01d84000 0 0x3000>,
> + <0 0x01da5000 0 0x2000>,
> + <0 0x01da4000 0 0x0010>;
These are wrong address spaces. Open your datasheet and look there.
Best regards,
Krzysztof
Powered by blists - more mailing lists