linux-kernel - Re: [PATCH v2 9/9] dt-bindings: nvmem: mediatek: efuse: Add support for MT8196

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250731102650.145641-1-laura.nao@collabora.com>
Date: Thu, 31 Jul 2025 12:26:50 +0200
From: Laura Nao <laura.nao@...labora.com>
To: robh@...nel.org
Cc: andrew-ct.chen@...iatek.com,
	angelogioacchino.delregno@...labora.com,
	arnd@...db.de,
	bchihi@...libre.com,
	colin.i.king@...il.com,
	conor+dt@...nel.org,
	daniel.lezcano@...aro.org,
	devicetree@...r.kernel.org,
	frank-w@...lic-files.de,
	kernel@...labora.com,
	krzk+dt@...nel.org,
	lala.lin@...iatek.com,
	laura.nao@...labora.com,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	linux-mediatek@...ts.infradead.org,
	linux-pm@...r.kernel.org,
	lukasz.luba@....com,
	matthias.bgg@...il.com,
	nfraprado@...labora.com,
	rafael@...nel.org,
	rui.zhang@...el.com,
	srini@...nel.org,
	u.kleine-koenig@...libre.com,
	wenst@...omium.org
Subject: Re: [PATCH v2 9/9] dt-bindings: nvmem: mediatek: efuse: Add support for MT8196

Hi Rob,

On 7/31/25 01:54, Rob Herring wrote:
> On Wed, Jul 30, 2025 at 05:21:28PM +0200, Laura Nao wrote:
>> The MT8196 eFuse layout is compatible with MT8186 and shares the same
>> decoding scheme for the gpu-speedbin cell.
>>
>> Signed-off-by: Laura Nao <laura.nao@...labora.com>
>> ---
>>  Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
>> index 4dc0d42df3e6..455b96c1e1f4 100644
>> --- a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
>> +++ b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
>> @@ -25,6 +25,7 @@ properties:
>>    compatible:
>>      oneOf:
>>        - items:
>> +          - const: mediatek,mt8196-efuse
>>            - const: mediatek,mt8188-efuse
>>            - const: mediatek,mt8186-efuse
>
> You just broke mt8188 as it had 2 entries and now has 3. I think 
> (based on the commit msg) you want to change 8188 entry to an enum with 
> mediatek,mt8196-efuse and mediatek,mt8188-efuse.
>

You're absolutely right, not sure how I missed that.
It should be:

  compatible:
    oneOf:
      - items:
          - enum:
              - mediatek,mt8196-efuse
              - mediatek,mt8188-efuse
          - const: mediatek,mt8186-efuse
      - const: mediatek,mt8186-efuse
[...]

I'll address it in v3.

Thanks!

Laura

>>        - const: mediatek,mt8186-efuse
>> -- 
>> 2.39.5
>>