linux-kernel - Re: [PATCH v2 6/9] thermal/drivers/mediatek/lvts: Add support for ATP mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC=S1ngjmk8-C0H2Nii4NXE3wsL1dYLQp-PXafG0=oaOVsYgmA@mail.gmail.com>
Date: Fri, 1 Aug 2025 12:44:19 +0800
From: Fei Shao <fshao@...omium.org>
To: Laura Nao <laura.nao@...labora.com>
Cc: andrew-ct.chen@...iatek.com, angelogioacchino.delregno@...labora.com, 
	arnd@...db.de, bchihi@...libre.com, colin.i.king@...il.com, 
	conor+dt@...nel.org, daniel.lezcano@...aro.org, devicetree@...r.kernel.org, 
	kernel@...labora.com, krzk+dt@...nel.org, lala.lin@...iatek.com, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	linux-mediatek@...ts.infradead.org, linux-pm@...r.kernel.org, 
	lukasz.luba@....com, matthias.bgg@...il.com, nfraprado@...labora.com, 
	rafael@...nel.org, robh@...nel.org, rui.zhang@...el.com, srini@...nel.org, 
	u.kleine-koenig@...libre.com, wenst@...omium.org
Subject: Re: [PATCH v2 6/9] thermal/drivers/mediatek/lvts: Add support for ATP mode

On Thu, Jul 31, 2025 at 6:15 PM Laura Nao <laura.nao@...labora.com> wrote:
>
> Hi Fei,
>
> On 7/31/25 06:25, Fei Shao wrote:
> > On Wed, Jul 30, 2025 at 11:40 PM Laura Nao <laura.nao@...labora.com> wrote:
> >>
> >> MT8196/MT6991 uses ATP (Abnormal Temperature Prevention) mode to detect
> >> abnormal temperature conditions, which involves reading temperature data
> >> from a dedicated set of registers separate from the ones used for
> >> immediate and filtered modes.
> >>
> >> Add support for ATP mode and its relative registers to ensure accurate
> >> temperature readings and proper thermal management on MT8196/MT6991
> >> devices.
> >>
> >> While at it, convert mode defines to enum.
> >>
> >> Reviewed-by: Chen-Yu Tsai <wenst@...omium.org>
> >> Signed-off-by: Laura Nao <laura.nao@...labora.com>
> >
> > It's not visible in this patch, but a heads-up that I see
> > lvts_ctrl_start() also depends on whether lvts is in immediate mode. I
> > wonder if anything is needed there for ATP mode e.g. a new
> > sensor_atp_bitmap.
> > Feel free to ignore if this is a false alarm.
> >
>
> Thanks for the heads up - the bitmap for ATP mode is the same as
> sensor_filt_bitmap, so the function is already working as intended.

Acknowledged, thanks for the clarification.

Reviewed-by: Fei Shao <fshao@...omium.org>

>
> Best,
>
> Laura
>
> > Regards,
> > Fei
>