linux-kernel - Re: [PATCH v2 8/9] thermal/drivers/mediatek/lvts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d117b30-1017-42db-af45-9d4137e9656d@collabora.com>
Date: Fri, 1 Aug 2025 09:28:46 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Laura Nao <laura.nao@...labora.com>, srini@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, rafael@...nel.org,
 daniel.lezcano@...aro.org, rui.zhang@...el.com, lukasz.luba@....com,
 matthias.bgg@...il.com
Cc: wenst@...omium.org, nfraprado@...labora.com, arnd@...db.de,
 colin.i.king@...il.com, u.kleine-koenig@...libre.com,
 andrew-ct.chen@...iatek.com, lala.lin@...iatek.com, bchihi@...libre.com,
 frank-w@...lic-files.de, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 kernel@...labora.com
Subject: Re: [PATCH v2 8/9] thermal/drivers/mediatek/lvts_thermal: Add MT8196
 support

Il 30/07/25 17:21, Laura Nao ha scritto:
> Add LVTS driver support for MT8196.
> 
> Signed-off-by: Laura Nao <laura.nao@...labora.com>

When changing commit 4/9, this also needs to follow with

const struct lvts_platform_ops lvts_platform_ops_v2 = {
	.lvts_raw_to_temp = lvts_raw_to_temp,
	.lvts_temp_to_raw = lvts_temp_to_raw_v2,
};

and

static const struct lvts_data mt8196_lvts_mcu_data = {
	.lvts_ctrl	= mt8196_lvts_mcu_data_ctrl,
	.num_lvts_ctrl	= ARRAY_SIZE(mt8196_lvts_mcu_data_ctrl),
	.temp_factor	= LVTS_COEFF_A_MT8196,
	.temp_offset	= LVTS_COEFF_B_MT8196,
	.gt_calib_bit_offset = 0,
	.def_calibration = 14437,
	.num_cal_offsets = 2,
	.msr_offset = LVTS_MSR_OFFSET_MT8196,
	.ops = lvts_platform_ops_v2,
};

static const struct lvts_data mt8196_lvts_ap_data = {
	.lvts_ctrl	= mt8196_lvts_ap_data_ctrl,
	.num_lvts_ctrl	= ARRAY_SIZE(mt8196_lvts_ap_data_ctrl),
	.temp_factor	= LVTS_COEFF_A_MT8196,
	.temp_offset	= LVTS_COEFF_B_MT8196,
	.gt_calib_bit_offset = 0,
	.def_calibration = 14437,
	.num_cal_offsets = 2,
	.msr_offset = LVTS_MSR_OFFSET_MT8196,
	.ops = lvts_platform_ops_v2,
};

After which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>