linux-kernel - Re: [PATCH v2 9/9] dt-bindings: nvmem: mediatek: efuse: Add support for MT8196

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2889bb9d-8d0d-44a9-a224-0d04562b4a0f@kernel.org>
Date: Sun, 3 Aug 2025 10:18:25 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Laura Nao <laura.nao@...labora.com>, robh@...nel.org
Cc: andrew-ct.chen@...iatek.com, angelogioacchino.delregno@...labora.com,
 arnd@...db.de, bchihi@...libre.com, colin.i.king@...il.com,
 conor+dt@...nel.org, daniel.lezcano@...aro.org, devicetree@...r.kernel.org,
 frank-w@...lic-files.de, kernel@...labora.com, krzk+dt@...nel.org,
 lala.lin@...iatek.com, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
 linux-pm@...r.kernel.org, lukasz.luba@....com, matthias.bgg@...il.com,
 nfraprado@...labora.com, rafael@...nel.org, rui.zhang@...el.com,
 srini@...nel.org, u.kleine-koenig@...libre.com, wenst@...omium.org
Subject: Re: [PATCH v2 9/9] dt-bindings: nvmem: mediatek: efuse: Add support
 for MT8196

On 31/07/2025 12:26, Laura Nao wrote:
>>>        - items:
>>> +          - const: mediatek,mt8196-efuse
>>>            - const: mediatek,mt8188-efuse
>>>            - const: mediatek,mt8186-efuse
>>
>> You just broke mt8188 as it had 2 entries and now has 3. I think 
>> (based on the commit msg) you want to change 8188 entry to an enum with 
>> mediatek,mt8196-efuse and mediatek,mt8188-efuse.
>>
> 
> You're absolutely right, not sure how I missed that.
Please test your bindings and DTS BEFORE you send. The testing would
point you new warnings.

Best regards,
Krzysztof