linux-kernel - Re: [PATCH net 2/2] selftests: bonding: add test for passive LACP mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aIyCfz3KUcYoE4Ix@fedora>
Date: Fri, 1 Aug 2025 09:01:51 +0000
From: Hangbin Liu <liuhangbin@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, Jay Vosburgh <jv@...sburgh.net>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Nikolay Aleksandrov <razor@...ckwall.org>,
	Simon Horman <horms@...nel.org>, Shuah Khan <shuah@...nel.org>,
	Jonathan Corbet <corbet@....net>, Petr Machata <petrm@...dia.com>,
	Amit Cohen <amcohen@...dia.com>,
	Vladimir Oltean <vladimir.oltean@....com>,
	Alessandro Zanni <alessandro.zanni87@...il.com>,
	linux-doc@...r.kernel.org, linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 2/2] selftests: bonding: add test for passive LACP
 mode

On Fri, Jul 25, 2025 at 07:21:12AM -0700, Jakub Kicinski wrote:
> On Fri, 25 Jul 2025 06:28:48 +0000 Hangbin Liu wrote:
> > Add a selftest to verify bonding behavior when `lacp_active` is set to `off`.
> > 
> > The test checks the following:
> > - The passive LACP bond should not send LACPDUs before receiving a partner's
> >   LACPDU.
> > - The transmitted LACPDUs must not include the active flag.
> > - After transitioning to EXPIRED and DEFAULTED states, the passive side should
> >   still not initiate LACPDUs.
> 
> Strangely this test fails on a normal kernel build but passes with
> debug options enabled:
> 
> https://netdev.bots.linux.dev/contest.html?branch=net-next-2025-07-25--09-00&test=bond-passive-lacp-sh

I guess on the normal kernel, the checking starts too soon before negotiation
finished. I will add some sleep time before checking.

Thanks
Hangbin