[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <69f2807c-9a28-4b31-97cc-2756f0ab9fd4@kernel.org>
Date: Fri, 1 Aug 2025 11:02:36 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sarthak Garg <quic_sartgarg@...cinc.com>,
Ulf Hansson <ulf.hansson@...aro.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>
Cc: linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
quic_cang@...cinc.com, quic_nguyenb@...cinc.com, quic_rampraka@...cinc.com,
quic_pragalla@...cinc.com, quic_sayalil@...cinc.com,
quic_nitirawa@...cinc.com, quic_bhaskarv@...cinc.com, kernel@....qualcomm.com
Subject: Re: [PATCH V4 4/4] arm64: dts: qcom: sm8550: Remove SDR104/SDR50
broken capabilities
On 01/08/2025 10:45, Sarthak Garg wrote:
> The kernel now handles level shifter limitations affecting SD card
> modes, making it unnecessary to explicitly disable SDR104 and SDR50
> capabilities in the device tree.
>
> However, due to board-specific hardware constraints particularly related
> to level shifter in this case the maximum frequency for SD High-Speed
> (HS) mode must be limited to 37.5 MHz to ensure reliable operation of SD
> card in HS mode. This is achieved using the max-sd-hs-frequency property
> in the board DTS.
>
> Signed-off-by: Sarthak Garg <quic_sartgarg@...cinc.com>
> ---
> arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 1 +
> arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 1 +
> arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts | 1 +
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 3 ---
> 4 files changed, 3 insertions(+), 3 deletions(-)
>
This will break MMC for all of the users and nothing in commit msg or
cover letter explains that or mentions merging strategy.
Exactly this case is covered by your internal guideline, no? Please read it.
Best regards,
Krzysztof
Powered by blists - more mailing lists