linux-kernel - Re: [PATCH 1/3] irqchip/gic-v5: iwb: Fix iounmap probe failure path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86tt2r6xdp.wl-maz@kernel.org>
Date: Fri, 01 Aug 2025 13:26:42 +0100
From: Marc Zyngier <maz@...nel.org>
To: Lorenzo Pieralisi <lpieralisi@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	Sascha Bischoff <sascha.bischoff@....com>,
	Timothy Hayes <timothy.hayes@....com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 1/3] irqchip/gic-v5: iwb: Fix iounmap probe failure path

On Fri, 01 Aug 2025 08:58:18 +0100,
Lorenzo Pieralisi <lpieralisi@...nel.org> wrote:
> 
> Kbot reported that on the failure path the driver
> iounmap() IWB resources that are managed through
> devm_ioremap(), which is clearly wrong because
> the driver would end up unmapping the MMIO
> resource twice on probing failure.
> 
> Fix this by removing the error path altogether
> and by letting devres manage the iounmapping
> on clean-up.
> 
> Fixes: 695949d8b16f ("irqchip/gic-v5: Add GICv5 IWB support")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202508010038.N3r4ZmII-lkp@intel.com
> Signed-off-by: Lorenzo Pieralisi <lpieralisi@...nel.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Marc Zyngier <maz@...nel.org>

Reviewed-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.