linux-kernel - Re: [PATCH 3/3] irqchip/gic-v5: Remove IRQD_RESEND_WHEN_IN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86seib6x7b.wl-maz@kernel.org>
Date: Fri, 01 Aug 2025 13:30:32 +0100
From: Marc Zyngier <maz@...nel.org>
To: Lorenzo Pieralisi <lpieralisi@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	Sascha Bischoff <sascha.bischoff@....com>,
	Timothy Hayes <timothy.hayes@....com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] irqchip/gic-v5: Remove IRQD_RESEND_WHEN_IN_PROGRESS for ITS IRQs

On Fri, 01 Aug 2025 08:58:20 +0100,
Lorenzo Pieralisi <lpieralisi@...nel.org> wrote:
> 
> GICv5 LPI interrupts have an active state hence they cannot retrigger
> while the IRQ is being handled.
> 
> Therefore setting IRQD_RESEND_WHEN_IN_PROGRESS for GICv5 ITS
> interrupts provides no benefit and it is useless (and confusing),
> it solves an issue that cannot happen.

This doesn't read very well. How about:

"Therefore, setting the IRQD_RESEND_WHEN_IN_PROGRESS flag on LPIs
 is pointless, as the situation this flag caters for cannot happen".

>
> Remove it.
> 
> Signed-off-by: Lorenzo Pieralisi <lpieralisi@...nel.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Marc Zyngier <maz@...nel.org>
> ---
>  drivers/irqchip/irq-gic-v5-its.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-its.c
> index 340640fdbdf6..9290ac741949 100644
> --- a/drivers/irqchip/irq-gic-v5-its.c
> +++ b/drivers/irqchip/irq-gic-v5-its.c
> @@ -973,7 +973,6 @@ static int gicv5_its_irq_domain_alloc(struct irq_domain *domain, unsigned int vi
>  		irqd = irq_get_irq_data(virq + i);
>  		irqd_set_single_target(irqd);
>  		irqd_set_affinity_on_activate(irqd);
> -		irqd_set_resend_when_in_progress(irqd);
>  	}
>  
>  	return 0;
> 

With that,

Reviewed-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.