[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250801133435.GA3024231-robh@kernel.org>
Date: Fri, 1 Aug 2025 08:34:35 -0500
From: Rob Herring <robh@...nel.org>
To: Andrew Lunn <andrew@...n.ch>,
Gregory Clement <gregory.clement@...tlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>,
Miquel Raynal <miquel.raynal@...tlin.com>
Cc: linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH] dt-binding: thermal: Convert
marvell,armada-ap806-thermal to DT schema
On Wed, Jul 02, 2025 at 06:00:29PM -0500, Rob Herring (Arm) wrote:
> Convert the Marvell Armada AP80x/CP110 thermal binding to schema. It is
> a straight forward conversion.
>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
> .../arm/marvell/ap80x-system-controller.txt | 39 ----------------
> .../arm/marvell/cp110-system-controller.txt | 43 ------------------
> .../thermal/marvell,armada-ap806-thermal.yaml | 44 +++++++++++++++++++
> 3 files changed, 44 insertions(+), 82 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/thermal/marvell,armada-ap806-thermal.yaml
Ping!
>
> diff --git a/Documentation/devicetree/bindings/arm/marvell/ap80x-system-controller.txt b/Documentation/devicetree/bindings/arm/marvell/ap80x-system-controller.txt
> index c83245065d44..72de11bd2ef0 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/ap80x-system-controller.txt
> +++ b/Documentation/devicetree/bindings/arm/marvell/ap80x-system-controller.txt
> @@ -115,45 +115,6 @@ ap_syscon: system-controller@...000 {
> SYSTEM CONTROLLER 1
> ===================
>
> -Thermal:
> ---------
> -
> -For common binding part and usage, refer to
> -Documentation/devicetree/bindings/thermal/thermal*.yaml
> -
> -The thermal IP can probe the temperature all around the processor. It
> -may feature several channels, each of them wired to one sensor.
> -
> -It is possible to setup an overheat interrupt by giving at least one
> -critical point to any subnode of the thermal-zone node.
> -
> -Required properties:
> -- compatible: must be one of:
> - * marvell,armada-ap806-thermal
> -- reg: register range associated with the thermal functions.
> -
> -Optional properties:
> -- interrupts: overheat interrupt handle. Should point to line 18 of the
> - SEI irqchip. See interrupt-controller/interrupts.txt
> -- #thermal-sensor-cells: shall be <1> when thermal-zones subnodes refer
> - to this IP and represents the channel ID. There is one sensor per
> - channel. O refers to the thermal IP internal channel, while positive
> - IDs refer to each CPU.
> -
> -Example:
> -ap_syscon1: system-controller@...000 {
> - compatible = "syscon", "simple-mfd";
> - reg = <0x6f8000 0x1000>;
> -
> - ap_thermal: thermal-sensor@80 {
> - compatible = "marvell,armada-ap806-thermal";
> - reg = <0x80 0x10>;
> - interrupt-parent = <&sei>;
> - interrupts = <18>;
> - #thermal-sensor-cells = <1>;
> - };
> -};
> -
> Cluster clocks:
> ---------------
>
> diff --git a/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt b/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt
> index 9d5d70c98058..54ff9f218328 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt
> +++ b/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt
> @@ -189,46 +189,3 @@ CP110_LABEL(syscon0): system-controller@...000 {
> };
>
> };
> -
> -SYSTEM CONTROLLER 1
> -===================
> -
> -Thermal:
> ---------
> -
> -The thermal IP can probe the temperature all around the processor. It
> -may feature several channels, each of them wired to one sensor.
> -
> -It is possible to setup an overheat interrupt by giving at least one
> -critical point to any subnode of the thermal-zone node.
> -
> -For common binding part and usage, refer to
> -Documentation/devicetree/bindings/thermal/thermal*.yaml
> -
> -Required properties:
> -- compatible: must be one of:
> - * marvell,armada-cp110-thermal
> -- reg: register range associated with the thermal functions.
> -
> -Optional properties:
> -- interrupts-extended: overheat interrupt handle. Should point to
> - a line of the ICU-SEI irqchip (116 is what is usually used by the
> - firmware). The ICU-SEI will redirect towards interrupt line #37 of the
> - AP SEI which is shared across all CPs.
> - See interrupt-controller/interrupts.txt
> -- #thermal-sensor-cells: shall be <1> when thermal-zones subnodes refer
> - to this IP and represents the channel ID. There is one sensor per
> - channel. O refers to the thermal IP internal channel.
> -
> -Example:
> -CP110_LABEL(syscon1): system-controller@...000 {
> - compatible = "syscon", "simple-mfd";
> - reg = <0x6f8000 0x1000>;
> -
> - CP110_LABEL(thermal): thermal-sensor@70 {
> - compatible = "marvell,armada-cp110-thermal";
> - reg = <0x70 0x10>;
> - interrupts-extended = <&CP110_LABEL(icu_sei) 116 IRQ_TYPE_LEVEL_HIGH>;
> - #thermal-sensor-cells = <1>;
> - };
> -};
> diff --git a/Documentation/devicetree/bindings/thermal/marvell,armada-ap806-thermal.yaml b/Documentation/devicetree/bindings/thermal/marvell,armada-ap806-thermal.yaml
> new file mode 100644
> index 000000000000..fdbdf3c1273a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/marvell,armada-ap806-thermal.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/marvell,armada-ap806-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell Armada AP80x/CP110 thermal management
> +
> +maintainers:
> + - Miquel Raynal <miquel.raynal@...tlin.com>
> +
> +properties:
> + compatible:
> + enum:
> + - marvell,armada-ap806-thermal
> + - marvell,armada-ap807-thermal
> + - marvell,armada-cp110-thermal
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + description: overheat interrupt
> + maxItems: 1
> +
> + '#thermal-sensor-cells':
> + description: Cell represents the channel ID. There is one sensor per
> + channel. O refers to the thermal IP internal channel.
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + thermal-sensor@80 {
> + compatible = "marvell,armada-ap806-thermal";
> + reg = <0x80 0x10>;
> + interrupts = <18>;
> + #thermal-sensor-cells = <1>;
> + };
> --
> 2.47.2
>
Powered by blists - more mailing lists