linux-kernel - Re: linux-6.16/fs/jffs2/readinode.c:189: loop can never finish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8114ae51-a238-40d3-9ecd-70e23abae28b@sigma-star.at>
Date: Mon, 4 Aug 2025 09:30:32 +0200
From: David Oberhollenzer <david.oberhollenzer@...ma-star.at>
To: Zhihao Cheng <chengzhihao1@...wei.com>,
 David Binderman <dcb314@...mail.com>,
 "dwmw2@...radead.org" <dwmw2@...radead.org>, "richard@....at"
 <richard@....at>,
 "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-6.16/fs/jffs2/readinode.c:189: loop can never finish

Hi,

On 8/4/25 9:10 AM, Zhihao Cheng wrote:
> 
> The 'next != NULL' is also a condition for the loop, this snippet of code finds a leaf node in 'tn_root'.

Yes, this is a classic tree traversal. Assuming the tree isn't
broken, the loop eventually terminates when it runs of a leaf.

The real issue with this code is that this is the *only* exit
condition of the loop. The traversal loop always branches until
it hits a leaf and the function then returns NULL. I'm pretty
sure this might not be the intended behavior.

Greetings,

David