linux-kernel - Re: [PATCH v2] arm64: dts: renesas: rzg2lc-smarc: Disable CAN-FD channel0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUzKFEjtft1krg=275yTdzE1v+c1VrvN5BmsLtes6LKuw@mail.gmail.com>
Date: Mon, 4 Aug 2025 10:03:21 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Biju <biju.das.au@...il.com>
Cc: Magnus Damm <magnus.damm@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Biju Das <biju.das.jz@...renesas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, linux-renesas-soc@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: renesas: rzg2lc-smarc: Disable CAN-FD channel0

Hi Biju,

Thanks for your patch!

On Fri, 1 Aug 2025 at 14:20, Biju <biju.das.au@...il.com> wrote:
> From: Biju Das <biju.das.jz@...renesas.com>
>
> On RZ/G2LC SMARC EVK, CAN-FD channel0 is not populated and channel0 is
> a required property. Currently we are deleting a wrong node. Fixing the

s/wrong/nonexistent/

> wrong node invoked dtb warning message. Disable CAN-FD channel0 instead
> of deleting the node.
>
> Fixes: 46da632734a5 ("arm64: dts: renesas: rzg2lc-smarc: Enable CANFD channel 1")
> Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> ---
> v1->v2:
>  * Updated the commit header and description.
>  * Fixed the bot warning by disabling the channel instead of deleting it.
> ---
>  arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> index 345b779e4f60..0d357516e0be 100644
> --- a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> @@ -48,7 +48,9 @@ sound_card {
>  #if (SW_SCIF_CAN || SW_RSPI_CAN)
>  &canfd {
>         pinctrl-0 = <&can1_pins>;
> -       /delete-node/ channel@0;

Please insert a blank line between properties and nodes.

> +       channel0 {
> +               status = "disabled";
> +       };
>  };
>  #else
>  &canfd {

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
i.e. will queue in renesas-devel for v6.18 with the above fixed.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds