linux-kernel - RE: [PATCH v2] arm64: dts: renesas: rzg2lc-smarc: Disable CAN-FD channel0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB11346EF73F28325EACCB9B4988623A@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Mon, 4 Aug 2025 09:04:59 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: geert <geert@...ux-m68k.org>, biju.das.au <biju.das.au@...il.com>
CC: magnus.damm <magnus.damm@...il.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] arm64: dts: renesas: rzg2lc-smarc: Disable CAN-FD
 channel0

Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Sent: 04 August 2025 09:03
> Subject: Re: [PATCH v2] arm64: dts: renesas: rzg2lc-smarc: Disable CAN-FD channel0
> 
> Hi Biju,
> 
> Thanks for your patch!
> 
> On Fri, 1 Aug 2025 at 14:20, Biju <biju.das.au@...il.com> wrote:
> > From: Biju Das <biju.das.jz@...renesas.com>
> >
> > On RZ/G2LC SMARC EVK, CAN-FD channel0 is not populated and channel0 is
> > a required property. Currently we are deleting a wrong node. Fixing
> > the
> 
> s/wrong/nonexistent/

Agreed.

> 
> > wrong node invoked dtb warning message. Disable CAN-FD channel0
> > instead of deleting the node.
> >
> > Fixes: 46da632734a5 ("arm64: dts: renesas: rzg2lc-smarc: Enable CANFD
> > channel 1")
> > Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> > ---
> > v1->v2:
> >  * Updated the commit header and description.
> >  * Fixed the bot warning by disabling the channel instead of deleting it.
> > ---
> >  arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> > b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> > index 345b779e4f60..0d357516e0be 100644
> > --- a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> > @@ -48,7 +48,9 @@ sound_card {
> >  #if (SW_SCIF_CAN || SW_RSPI_CAN)
> >  &canfd {
> >         pinctrl-0 = <&can1_pins>;
> > -       /delete-node/ channel@0;
> 
> Please insert a blank line between properties and nodes.

Ok.

> 
> > +       channel0 {
> > +               status = "disabled";
> > +       };
> >  };
> >  #else
> >  &canfd {
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be> i.e. will queue in renesas-devel for v6.18
> with the above fixed.


Thanks for taking care this.

Cheers,
Biju