linux-kernel - Re: [PATCH v3 09/27] dt-bindings: clock: mediatek: Describe MT8196 clock controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <373f44c3-8a6a-4d52-ba6b-4c9484e2eac1@kernel.org>
Date: Mon, 4 Aug 2025 11:16:56 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Laura Nao <laura.nao@...labora.com>
Cc: angelogioacchino.delregno@...labora.com, conor+dt@...nel.org,
 devicetree@...r.kernel.org, guangjie.song@...iatek.com,
 kernel@...labora.com, krzk+dt@...nel.org,
 linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
 matthias.bgg@...il.com, mturquette@...libre.com, netdev@...r.kernel.org,
 nfraprado@...labora.com, p.zabel@...gutronix.de, richardcochran@...il.com,
 robh@...nel.org, sboyd@...nel.org, wenst@...omium.org
Subject: Re: [PATCH v3 09/27] dt-bindings: clock: mediatek: Describe MT8196
 clock controllers

On 04/08/2025 10:35, Laura Nao wrote:
> Hi,
> 
> On 8/3/25 10:17, Krzysztof Kozlowski wrote:
>> On 01/08/2025 15:57, Rob Herring wrote:
>>>> +  reg:
>>>> +    maxItems: 1
>>>> +
>>>> +  '#clock-cells':
>>>> +    const: 1
>>>> +
>>>> +  '#reset-cells':
>>>> +    const: 1
>>>> +    description:
>>>> +      Reset lines for PEXTP0/1 and UFS blocks.
>>>> +
>>>> +  mediatek,hardware-voter:
>>>> +    $ref: /schemas/types.yaml#/definitions/phandle
>>>> +    description:
>>>> +      On the MT8196 SoC, a Hardware Voter (HWV) backed by a fixed-function
>>>> +      MCU manages clock and power domain control across the AP and other
>>>> +      remote processors. By aggregating their votes, it ensures clocks are
>>>> +      safely enabled/disabled and power domains are active before register
>>>> +      access.
>>>
>>> I thought this was going away based on v2 discussion?
>>
>> Yes, I asked to drop it and do not include it in v3. There was also
>> discussion clarifying review.
>>
>> I am really surprised that review meant nothing and code is still the same.
>>
> 
> This has been re-submitted as-is, following the outcome of the discussion 
> here: https://lore.kernel.org/all/242bf682-cf8f-4469-8a0b-9ec982095f04@collabora.com/
> 
> We haven't found a viable alternative to the current approach so far, and
> the thread outlines why other options don’t apply. I'm happy to continue 
> the discussion there if anyone has further suggestions or ideas on how 
> to address this.
> 

And where is any of that resolution/new facts in the commit msg? You
must clearly reflect long discussions like that in the commit msg.

There was no objection from Chen to use clocks or power domains as I
requested. The objection was about DUPLICATING interfaces or nodes.

And what was the resolution:

"Regarding that to be a single clock controller,"

So where is the clock controller? I still see HW voter!


Best regards,
Krzysztof