linux-kernel - [PATCH] bus: ti-sysc: Fix potential double free in sysc_add_named_clock_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250804120403.97959-1-linmq006@gmail.com>
Date: Mon,  4 Aug 2025 20:04:03 +0800
From: Miaoqian Lin <linmq006@...il.com>
To: Aaro Koskinen <aaro.koskinen@....fi>,
	Andreas Kemnade <andreas@...nade.info>,
	Kevin Hilman <khilman@...libre.com>,
	Roger Quadros <rogerq@...nel.org>,
	Tony Lindgren <tony@...mide.com>,
	linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: linmq006@...il.com
Subject: [PATCH] bus: ti-sysc: Fix potential double free in sysc_add_named_clock_from_child()

The devm_get_clk_from_child() function uses device-managed resources
that are automatically cleaned up. The clk_put() call after
devm_get_clk_from_child() is redundant and
may lead to double-free issues.

Fixes: a54275f4ab20 ("bus: ti-sysc: Add quirk handling for external optional functional clock")
Signed-off-by: Miaoqian Lin <linmq006@...il.com>
---
 drivers/bus/ti-sysc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
index 9f624e5da991..5441b0739faa 100644
--- a/drivers/bus/ti-sysc.c
+++ b/drivers/bus/ti-sysc.c
@@ -362,7 +362,6 @@ static int sysc_add_named_clock_from_child(struct sysc *ddata,
 	cl->clk = clock;
 	clkdev_add(cl);
 
-	clk_put(clock);
 
 	return 0;
 }
-- 
2.35.1