[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250804120828.309790-1-hansg@kernel.org>
Date: Mon, 4 Aug 2025 14:08:28 +0200
From: Hans de Goede <hansg@...nel.org>
To: Lee Jones <lee@...nel.org>,
Andy Shevchenko <andy@...nel.org>
Cc: Hans de Goede <hansg@...nel.org>,
linux-kernel@...r.kernel.org,
stable@...r.kernel.org
Subject: [PATCH v2] mfd: intel_soc_pmic_chtdc_ti: Set use_single_read regmap_config flag
Testing has shown that reading multiple registers at once (for 10 bit
adc values) does not work. Set the use_single_read regmap_config flag
to make regmap split these for is.
This should fix temperature opregion accesses done by
drivers/acpi/pmic/intel_pmic_chtdc_ti.c and is also necessary for
the upcoming drivers for the ADC and battery MFD cells.
Fixes: 6bac0606fdba ("mfd: Add support for Cherry Trail Dollar Cove TI PMIC")
Cc: stable@...r.kernel.org
Reviewed-by: Andy Shevchenko <andy@...nel.org>
Signed-off-by: Hans de Goede <hansg@...nel.org>
---
Changes in v2:
- Update comment to: "The hardware does not support reading multiple
registers at once"
---
drivers/mfd/intel_soc_pmic_chtdc_ti.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/intel_soc_pmic_chtdc_ti.c b/drivers/mfd/intel_soc_pmic_chtdc_ti.c
index 4c1a68c9f575..6daf33e07ea0 100644
--- a/drivers/mfd/intel_soc_pmic_chtdc_ti.c
+++ b/drivers/mfd/intel_soc_pmic_chtdc_ti.c
@@ -82,6 +82,8 @@ static const struct regmap_config chtdc_ti_regmap_config = {
.reg_bits = 8,
.val_bits = 8,
.max_register = 0xff,
+ /* The hardware does not support reading multiple registers at once */
+ .use_single_read = true,
};
static const struct regmap_irq chtdc_ti_irqs[] = {
--
2.49.0
Powered by blists - more mailing lists