linux-kernel - Re: [PATCH] crypto: ccp: Fix checks for SNP_VLEK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250805180528.GGaJJH6PjqvB1AJYLR@fat_crate.local>
Date: Tue, 5 Aug 2025 20:05:28 +0200
From: Borislav Petkov <bp@...en8.de>
To: Michael Roth <michael.roth@....com>,
	Herbert Xu <herbert@...dor.apana.org.au>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org,
	Diego GonzalezVillalobos <Diego.GonzalezVillalobos@....com>
Subject: Re: [PATCH] crypto: ccp: Fix checks for SNP_VLEK_LOAD input buffer
 length

I think this should go to Herbert who's collecting crypto stuff.

 To: x86@...nel.org is perhaps not really the right place :)

On Mon, Jul 28, 2025 at 06:43:03PM -0500, Michael Roth wrote:
> The SNP_VLEK_LOAD IOCTL currently fails due to sev_cmd_buffer_len()
> returning the default expected buffer length of 0 instead of the correct
> value, which would be sizeof(struct sev_user_data_snp_vlek_load). Add
> specific handling for SNP_VLEK_LOAD so the correct expected size is
> returned.
> 
> Reported-by: Diego GonzalezVillalobos <Diego.GonzalezVillalobos@....com>
> Cc: Diego GonzalezVillalobos <Diego.GonzalezVillalobos@....com>
> Fixes: 332d2c1d713e ("crypto: ccp: Add the SNP_VLEK_LOAD command")
> Signed-off-by: Michael Roth <michael.roth@....com>
> ---
>  drivers/crypto/ccp/sev-dev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c
> index 3451bada884e..7843973ba4c6 100644
> --- a/drivers/crypto/ccp/sev-dev.c
> +++ b/drivers/crypto/ccp/sev-dev.c
> @@ -233,6 +233,7 @@ static int sev_cmd_buffer_len(int cmd)
>  	case SEV_CMD_SNP_GUEST_REQUEST:		return sizeof(struct sev_data_snp_guest_request);
>  	case SEV_CMD_SNP_CONFIG:		return sizeof(struct sev_user_data_snp_config);
>  	case SEV_CMD_SNP_COMMIT:		return sizeof(struct sev_data_snp_commit);
> +	case SEV_CMD_SNP_VLEK_LOAD:		return sizeof(struct sev_user_data_snp_vlek_load);
>  	default:				return 0;
>  	}
>  
> -- 
> 2.25.1
> 

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette