linux-kernel - Re: [PATCH net-next v4 7/7] net: axienet: Split into MAC and MDIO drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3c426447-e2b9-4c81-8fc2-7cf7e36660d2@linux.dev>
Date: Tue, 5 Aug 2025 18:02:45 -0400
From: Sean Anderson <sean.anderson@...ux.dev>
To: Andrew Lunn <andrew@...n.ch>
Cc: Radhey Shyam Pandey <radhey.shyam.pandey@....com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Michal Simek <michal.simek@....com>,
 Leon Romanovsky <leon@...nel.org>
Subject: Re: [PATCH net-next v4 7/7] net: axienet: Split into MAC and MDIO
 drivers

On 8/5/25 17:40, Andrew Lunn wrote:
>> Fixes: 1a02556086fc ("net: axienet: Properly handle PCS/PMA PHY for 1000BaseX mode")
> 
> If this is for net-next, please don't have a Fixes: tag.

This is a fix. But as explained in the cover letter this is quite an
involved fix for an uncommon bug. I can target net if you like.

>>  struct axienet_common {
>>  	struct platform_device *pdev;
>> +	struct auxiliary_device mac;
>>  
>>  	struct clk *axi_clk;
>>  
>>  	struct mutex reset_lock;
>> -	struct mii_bus *mii_bus;
>> +	struct auxiliary_device mii_bus;
> 
> Keeping the name mii_bus for something which is not an struct mii_bus
> is going to cause confusion. Please give it a different name.

Like mdio?

> This is another patch which needs splitting up.

I don't think it can be split up in any major way. The whole conversion
of the MAC/MDIO portions of the driver has to be done at the same time
as the parent driver is converted to use them.

--Sean