linux-kernel - RE: [PATCH net-next v4 1/7] net: axienet: Fix resource release ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SA1PR12MB6798CD01D26F4A68D6F7A214C9AAA@SA1PR12MB6798.namprd12.prod.outlook.com>
Date: Tue, 16 Dec 2025 11:53:00 +0000
From: "Gupta, Suraj" <Suraj.Gupta2@....com>
To: Andrew Lunn <andrew@...n.ch>, Sean Anderson <sean.anderson@...ux.dev>
CC: "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S . Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, "Simek, Michal" <michal.simek@....com>, Leon
 Romanovsky <leon@...nel.org>
Subject: RE: [PATCH net-next v4 1/7] net: axienet: Fix resource release
 ordering

[Public]

Hi,
> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Wednesday, August 6, 2025 2:29 AM
> To: Sean Anderson <sean.anderson@...ux.dev>
> Cc: Pandey, Radhey Shyam <radhey.shyam.pandey@....com>; Andrew Lunn
> <andrew+netdev@...n.ch>; David S . Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; netdev@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>; Simek, Michal <michal.simek@....com>;
> Leon Romanovsky <leon@...nel.org>; Gupta, Suraj <Suraj.Gupta2@....com>
> Subject: Re: [PATCH net-next v4 1/7] net: axienet: Fix resource release ordering
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> > +static void axienet_disable_misc(void *clocks) {
> > +     clk_bulk_disable_unprepare(XAE_NUM_MISC_CLOCKS, clocks); }
> > +
>
> ...
>
> >       ret = devm_clk_bulk_get_optional(&pdev->dev, XAE_NUM_MISC_CLOCKS,
> lp->misc_clks);
> >       if (ret)
> > -             goto cleanup_clk;
> > +             return dev_err_probe(&pdev->dev, ret,
> > +                                  "could not get misc. clocks\n");
> >
> >       ret = clk_bulk_prepare_enable(XAE_NUM_MISC_CLOCKS, lp->misc_clks);
> >       if (ret)
> > -             goto cleanup_clk;
> > +             return dev_err_probe(&pdev->dev, ret,
> > +                                  "could not enable misc. clocks\n");
> > +
> > +     ret = devm_add_action_or_reset(&pdev->dev, axienet_disable_misc,
> > +                                    lp->misc_clks);
>
> It seems like it would be better to add
> devm_clk_bulk_get_optional_enable(). There is already an
> devm_clk_bulk_get_all_enabled() so it does not seem like too big a step.
>
>         Andrew

We are interested in this patch to fix AXI Ethernet probe path and can collaborate on upstreaming it.

Regards,
Suraj