linux-kernel - Re: [PATCH net-next v4 1/7] net: axienet: Fix resource release ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <540737b2-f155-4c55-ab95-b18f113e0031@linux.dev>
Date: Tue, 16 Dec 2025 09:48:00 -0500
From: Sean Anderson <sean.anderson@...ux.dev>
To: "Gupta, Suraj" <Suraj.Gupta2@....com>, Andrew Lunn <andrew@...n.ch>
Cc: "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Simek, Michal" <michal.simek@....com>, Leon Romanovsky <leon@...nel.org>
Subject: Re: [PATCH net-next v4 1/7] net: axienet: Fix resource release
 ordering

On 12/16/25 06:53, Gupta, Suraj wrote:
> [Public]
> 
> Hi,
>> -----Original Message-----
>> From: Andrew Lunn <andrew@...n.ch>
>> Sent: Wednesday, August 6, 2025 2:29 AM
>> To: Sean Anderson <sean.anderson@...ux.dev>
>> Cc: Pandey, Radhey Shyam <radhey.shyam.pandey@....com>; Andrew Lunn
>> <andrew+netdev@...n.ch>; David S . Miller <davem@...emloft.net>; Eric
>> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
>> Abeni <pabeni@...hat.com>; netdev@...r.kernel.org; linux-arm-
>> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; Greg Kroah-Hartman
>> <gregkh@...uxfoundation.org>; Simek, Michal <michal.simek@....com>;
>> Leon Romanovsky <leon@...nel.org>; Gupta, Suraj <Suraj.Gupta2@....com>
>> Subject: Re: [PATCH net-next v4 1/7] net: axienet: Fix resource release ordering
>>
>> Caution: This message originated from an External Source. Use proper caution
>> when opening attachments, clicking links, or responding.
>>
>>
>> > +static void axienet_disable_misc(void *clocks) {
>> > +     clk_bulk_disable_unprepare(XAE_NUM_MISC_CLOCKS, clocks); }
>> > +
>>
>> ...
>>
>> >       ret = devm_clk_bulk_get_optional(&pdev->dev, XAE_NUM_MISC_CLOCKS,
>> lp->misc_clks);
>> >       if (ret)
>> > -             goto cleanup_clk;
>> > +             return dev_err_probe(&pdev->dev, ret,
>> > +                                  "could not get misc. clocks\n");
>> >
>> >       ret = clk_bulk_prepare_enable(XAE_NUM_MISC_CLOCKS, lp->misc_clks);
>> >       if (ret)
>> > -             goto cleanup_clk;
>> > +             return dev_err_probe(&pdev->dev, ret,
>> > +                                  "could not enable misc. clocks\n");
>> > +
>> > +     ret = devm_add_action_or_reset(&pdev->dev, axienet_disable_misc,
>> > +                                    lp->misc_clks);
>>
>> It seems like it would be better to add
>> devm_clk_bulk_get_optional_enable(). There is already an
>> devm_clk_bulk_get_all_enabled() so it does not seem like too big a step.
>>
>>         Andrew
> 
> We are interested in this patch to fix AXI Ethernet probe path and can collaborate on upstreaming it.

Feel free to modify it as suggested by Andrew.

Unfortunately I have not had time to work on this series recently and probably
won't be able to return to it for another few months.

--Sean