linux-kernel - Re: [PATCH] pinctrl: spacemit: remove extra line in debug output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250805224149-GYA950625@gentoo>
Date: Wed, 6 Aug 2025 06:41:49 +0800
From: Yixun Lan <dlan@...too.org>
To: Hendrik Hamerlinck <hendrik.hamerlinck@...mernet.be>
Cc: linus.walleij@...aro.org, skhan@...uxfoundation.org,
	linux-kernel-mentees@...ts.linux.dev, linux-gpio@...r.kernel.org,
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: spacemit: remove extra line in debug output

Hi Hendrik, 
On 17:07 Tue 05 Aug     , Hendrik Hamerlinck wrote:
> The debug output for spacemit_pinconf_dbg_show() prints an extra newline
> at the end. This is redundant as pinconf_pins_show() in pinconf.c already
> adds a newline in its for loop.
> 
> Remove the newline to avoid the extra line in the output.
> 
> Example current output:
> $ cat /sys/kernel/debug/pinctrl/d401e000.pinctrl/pinconf-pins
> Pin config settings per pin
> Format: pin (name): configs
> pin 0 (GPIO_00): , bias pull disabled, io type (Fixed/1V8), drive strength (32 mA), register (0x1041)
> 
> pin 1 (GPIO_01): slew rate (0x0), bias pull disabled, io type (Fixed/1V8), drive strength (32 mA), register (0x1041)
> 
> pin 2 (GPIO_02): slew rate (0x0), bias pull disabled, io type (Fixed/1V8), drive strength (32 mA), register (0x1041)
> 
> ...
> 
> Signed-off-by: Hendrik Hamerlinck <hendrik.hamerlinck@...mernet.be>
Reviewed-by: Yixun Lan <dlan@...too.org>
> ---
>  drivers/pinctrl/spacemit/pinctrl-k1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/spacemit/pinctrl-k1.c b/drivers/pinctrl/spacemit/pinctrl-k1.c
> index 9996b1c4a07e..fb361f2acb54 100644
> --- a/drivers/pinctrl/spacemit/pinctrl-k1.c
> +++ b/drivers/pinctrl/spacemit/pinctrl-k1.c
> @@ -707,7 +707,7 @@ static void spacemit_pinconf_dbg_show(struct pinctrl_dev *pctldev,
>  			   spacemit_get_drive_strength_mA(IO_TYPE_1V8, tmp),
>  			   spacemit_get_drive_strength_mA(IO_TYPE_3V3, tmp));
>  
> -	seq_printf(seq, ", register (0x%04x)\n", value);
> +	seq_printf(seq, ", register (0x%04x)", value);
>  }
>  
>  static const struct pinconf_ops spacemit_pinconf_ops = {
> -- 
> 2.43.0
> 

-- 
Yixun Lan (dlan)