[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b5ba5a22-dc0a-423b-963f-5db6c7e04665@kernel.org>
Date: Tue, 5 Aug 2025 08:02:55 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Brandon Brnich <b-brnich@...com>, linux-kernel@...r.kernel.org
Cc: Nishanth Menon <nm@...com>, Vignesh Raghavendra <vigneshr@...com>,
Tero Kristo <kristo@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, linux-arm-kernel@...ts.infradead.org,
devicetree@...r.kernel.org, Devarsh Thakkar <devarsht@...com>,
Udit Kumar <u-kumar1@...com>, Darren Etheridge <detheridge@...com>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j722s-main: Add E5010 JPEG Encoder
On 04/08/2025 20:01, Brandon Brnich wrote:
> This adds node for E5010 JPEG Encoder which is a stateful JPEG Encoder
> present in J722s SoC, supporting baseline encoding of semiplanar based
> YUV420 and YUV422 raw video formats to JPEG encoding, with resolutions
> supported from 64x64 to 8kx8k.
>
> Signed-off-by: Brandon Brnich <b-brnich@...com>
> ---
>
> Changes in v2:
> - remove invalid clock-names attribute
>
> arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
> index 5cfa7bf36641..fb24c14614b4 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
> @@ -385,6 +385,16 @@ c7x_1: dsp@...00000 {
> ti,sci-proc-ids = <0x31 0xff>;
> status = "disabled";
> };
> +
> + e5010: e5010@...0000 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "img,e5010-jpeg-enc";
Wrong compatible. This is TI, not IMG.
Best regards,
Krzysztof
Powered by blists - more mailing lists