linux-kernel - Re: [PATCH v2] arm64: dts: ti: k3-j722s-main: Add E5010 JPEG Encoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b52fd6d4-b907-44dd-bd9b-e15c3321ad79@ti.com>
Date: Tue, 5 Aug 2025 08:34:55 -0500
From: Brandon Brnich <b-brnich@...com>
To: Krzysztof Kozlowski <krzk@...nel.org>, <linux-kernel@...r.kernel.org>
CC: Nishanth Menon <nm@...com>, Vignesh Raghavendra <vigneshr@...com>,
        Tero
 Kristo <kristo@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        Devarsh
 Thakkar <devarsht@...com>, Udit Kumar <u-kumar1@...com>,
        Darren Etheridge
	<detheridge@...com>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j722s-main: Add E5010 JPEG Encoder

Hi Krzysztof,

Thanks for the review.

On 8/5/2025 1:02 AM, Krzysztof Kozlowski wrote:
> On 04/08/2025 20:01, Brandon Brnich wrote:
>> This adds node for E5010 JPEG Encoder which is a stateful JPEG Encoder
>> present in J722s SoC, supporting baseline encoding of semiplanar based
>> YUV420 and YUV422 raw video formats to JPEG encoding, with resolutions
>> supported from 64x64 to 8kx8k.
>>
>> Signed-off-by: Brandon Brnich <b-brnich@...com>
>> ---
>>
>> Changes in v2:
>>    - remove invalid clock-names attribute
>>
>>   arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
>> index 5cfa7bf36641..fb24c14614b4 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
>> @@ -385,6 +385,16 @@ c7x_1: dsp@...00000 {
>>   		ti,sci-proc-ids = <0x31 0xff>;
>>   		status = "disabled";
>>   	};
>> +
>> +	e5010: e5010@...0000 {
> 
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

I got this name from the already present node in the am62a device 
tree[0]. Should I replace both of these with more generic name such as 
jpegenc?

> 
> 
>> +		compatible = "img,e5010-jpeg-enc";
> 
> Wrong compatible. This is TI, not IMG.

Devarsh has pointed out the same, I will update compatible that matches 
TI version in v3.

Best,
Brandon

[0]: 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi#n1149

> 
> 
> Best regards,
> Krzysztof