linux-kernel - [PATCH v1] VSOCK: fix Out-of-Bounds Read in vmci_transport_dgram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250805062041.1804857-1-tcs_kernel@tencent.com>
Date: Tue,  5 Aug 2025 14:20:41 +0800
From: bsdhenrymartin@...il.com
To: huntazhang@...cent.com,
	jitxie@...cent.com,
	landonsun@...cent.com,
	bryan-bt.tan@...adcom.com,
	vishnu.dasa@...adcom.com,
	bcm-kernel-feedback-list@...adcom.com,
	sgarzare@...hat.com,
	davem@...emloft.net,
	edumazet@...gle.com,
	kuba@...nel.org,
	pabeni@...hat.com,
	horms@...nel.org
Cc: linux-kernel@...r.kernel.org,
	virtualization@...ts.linux.dev,
	netdev@...r.kernel.org,
	bsdhenrymartin@...il.com,
	Henry Martin <bsdhenryma@...cent.com>,
	TCS Robot <tcs_robot@...cent.com>
Subject: [PATCH v1] VSOCK: fix Out-of-Bounds Read in vmci_transport_dgram_dequeue()

From: Henry Martin <bsdhenryma@...cent.com>

vmci_transport_dgram_dequeue lack of buffer length validation before
accessing `vmci_datagram` header.

Trigger Path:
1. Attacker sends a datagram with length < sizeof(struct
   vmci_datagram).
2. `skb_recv_datagram()` returns the malformed sk_buff (skb->len <
   sizeof(struct vmci_datagram)).
3. Code casts skb->data to struct vmci_datagram *dg without verifying
   skb->len.
4. Accessing `dg->payload_size` (Line: `payload_len =
   dg->payload_size;`) reads out-of-bounds memory.

Fixes: d021c344051a ("VSOCK: Introduce VM Sockets")
Reported-by: TCS Robot <tcs_robot@...cent.com>
Signed-off-by: Henry Martin <bsdhenryma@...cent.com>
---
 net/vmw_vsock/vmci_transport.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c
index 7eccd6708d66..0be605e19b2e 100644
--- a/net/vmw_vsock/vmci_transport.c
+++ b/net/vmw_vsock/vmci_transport.c
@@ -1749,6 +1749,11 @@ static int vmci_transport_dgram_dequeue(struct vsock_sock *vsk,
 	if (!skb)
 		return err;
 
+	if (skb->len < sizeof(struct vmci_datagram)) {
+		err = -EINVAL;
+		goto out;
+	}
+
 	dg = (struct vmci_datagram *)skb->data;
 	if (!dg)
 		/* err is 0, meaning we read zero bytes. */
-- 
2.41.3