linux-kernel - Re: [PATCH 1/2] dt-bindings: hwmon: adm1275: add sq24905c support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250805-ruby-earthworm-of-cubism-4d1c8a@kuoka>
Date: Tue, 5 Aug 2025 08:58:28 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Guenter Roeck <linux@...ck-us.net>
Cc: ChiShih Tsai <tomtsai764@...il.com>, linux-hwmon@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, 
	jdelvare@...e.com, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	corbet@....net, t630619@...il.com
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: adm1275: add sq24905c support

On Mon, Aug 04, 2025 at 08:59:09AM -0700, Guenter Roeck wrote:
> >   allOf:
> >     - $ref: hwmon-common.yaml#
> >     - if:
> > @@ -96,12 +109,17 @@ allOf:
> >                 - adi,adm1281
> >                 - adi,adm1293
> >                 - adi,adm1294
> > +              - silergy,sq24905c
> >       then:
> >         properties:
> >           adi,volt-curr-sample-average:
> >             default: 128
> >           adi,power-sample-average:
> >             default: 1
> > +        silergy,volt-curr-sample-average:
> > +          default: 128
> > +        silergy,power-sample-average:
> > +          default: 1
> 
> I personally don't think this warrants new properties. However, if warranted,

These are the same properties as adi ones, right? Then I agree, re-use
existing ones.

Best regards,
Krzysztof