linux-kernel - Re: [PATCH] net: wireless: rt2x00: fix CRC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMhs-H8zVcDtbeXQ32aw2gO2D8tkykwTOfoqxxK7PVwM_QPLiA@mail.gmail.com>
Date: Tue, 5 Aug 2025 08:59:05 +0200
From: Sergio Paracuellos <sergio.paracuellos@...il.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Stanislaw Gruszka <stf_xl@...pl>, Rosen Penev <rosenp@...il.com>, 
	Johannes Berg <johannes.berg@...el.com>, Arnd Bergmann <arnd@...db.de>, linux-wireless@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: wireless: rt2x00: fix CRC_CCITT dependency

On Thu, Jul 31, 2025 at 9:58 AM Arnd Bergmann <arnd@...nel.org> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
>
> Compile-testing this driver on Arm platforms shows a link failure
> when the CRC functions are not part of the kernel:
>
> x86_64-linux-ld: drivers/net/wireless/ralink/rt2x00/rt2800lib.o: in function `rt2800_check_firmware':
> rt2800lib.c:(.text+0x20e5): undefined reference to `crc_ccitt'
>
> Move the select statement to the correct Kconfig symbol to match
> the call site.
>
> Fixes: 311b05e235cf ("wifi: rt2x00: add COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/net/wireless/ralink/rt2x00/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Sergio Paracuellos <sergio.paracuellos@...il.com>