linux-kernel - Re: [PATCH v2] tools/rtla: Consolidate common parameters into shared structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADDUTFzWBkrKx6=fOMXp=y5cyecOvWLx5jZG6m3BMTAvL067Wg@mail.gmail.com>
Date: Tue, 5 Aug 2025 10:03:40 +0300
From: Costa Shulyupin <costa.shul@...hat.com>
To: Crystal Wood <crwood@...hat.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, Tomas Glozar <tglozar@...hat.com>, 
	John Kacur <jkacur@...hat.com>, Eder Zulian <ezulian@...hat.com>, 
	Dan Carpenter <dan.carpenter@...aro.org>, Jan Stancek <jstancek@...hat.com>, 
	linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	bpf@...r.kernel.org
Subject: Re: [PATCH v2] tools/rtla: Consolidate common parameters into shared structure

On Mon, 4 Aug 2025 at 21:18, Crystal Wood <crwood@...hat.com> wrote:
> If you want, I could rebase that on this and use container_of() to for tool-
> specific params... but then that adds complexity with the top and hist-
> specific params, most of which are common between timerlat and osnoise
> (and not merged by this patch).
I’d appreciate it if you could rebase your patchset on top of this one.
This patch is just the first; I’ve intentionally kept it minimal to
ease integration.
My goal is to refactor rtla and submit a series of follow-up patches
to reduce code duplication.

> So we might want to just keep it simple with one big struct.
This is a god object anti-pattern.

> new common.h if we want to keep the actual-osnoise-tracer stuff
> separate
I agree with the new common.h and separating things out.

-Costa