linux-kernel - Re: [PATCH v2] tools/rtla: Consolidate common parameters into shared structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <540bd149b88a543e306762fbf00c366a4f9670ce.camel@redhat.com>
Date: Tue, 05 Aug 2025 11:49:50 -0500
From: Crystal Wood <crwood@...hat.com>
To: Costa Shulyupin <costa.shul@...hat.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, Tomas Glozar <tglozar@...hat.com>,
  John Kacur <jkacur@...hat.com>, Eder Zulian <ezulian@...hat.com>, Dan
 Carpenter <dan.carpenter@...aro.org>,  Jan Stancek <jstancek@...hat.com>,
 linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	bpf@...r.kernel.org
Subject: Re: [PATCH v2] tools/rtla: Consolidate common parameters into
 shared structure

On Tue, 2025-08-05 at 10:03 +0300, Costa Shulyupin wrote:
> On Mon, 4 Aug 2025 at 21:18, Crystal Wood <crwood@...hat.com> wrote:
> > If you want, I could rebase that on this and use container_of() to for tool-
> > specific params... but then that adds complexity with the top and hist-
> > specific params, most of which are common between timerlat and osnoise
> > (and not merged by this patch).
> I’d appreciate it if you could rebase your patchset on top of this one.

OK.

> This patch is just the first; I’ve intentionally kept it minimal to
> ease integration.
> My goal is to refactor rtla and submit a series of follow-up patches
> to reduce code duplication.

I have consolidation patches that are just about ready to submit; I'll
try to get them polished and pushed soon.

> So we might want to just keep it simple with one big struct.
> This is a god object anti-pattern.

I know, but I was trying to weigh that against pragmatism and churn
reduction, at least for an initial refactoring -- particularly given
that my motivation was to make it easier to make a timerlat-specific
feature work on osnoise as well.

-Crystal