linux-kernel - Re: [PATCH 2/3] KEYS: trusted_tpm1: Use SHA-1 library instead of crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJIK33R5lgNYb2fR@kernel.org>
Date: Tue, 5 Aug 2025 16:45:03 +0300
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: James Bottomley <James.Bottomley@...senpartnership.com>,
	Mimi Zohar <zohar@...ux.ibm.com>, keyrings@...r.kernel.org,
	David Howells <dhowells@...hat.com>,
	linux-integrity@...r.kernel.org, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] KEYS: trusted_tpm1: Use SHA-1 library instead of
 crypto_shash

On Thu, Jul 31, 2025 at 02:23:53PM -0700, Eric Biggers wrote:
> Use the SHA-1 and HMAC-SHA1 library functions instead of crypto_shash.
> This is simpler and faster.
> 
> Replace the selection of CRYPTO, CRYPTO_HMAC, and CRYPTO_SHA1 with
> CRYPTO_LIB_SHA1 and CRYPTO_LIB_UTILS.  The latter is needed for
> crypto_memneq() which was previously being pulled in via CRYPTO.
> 
> Signed-off-by: Eric Biggers <ebiggers@...nel.org>
 
Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

BR, Jarkko