[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMvTesBzQtURO1xSoUuortdEp5kPo7ds9BX+Au-8donogWZg-g@mail.gmail.com>
Date: Tue, 5 Aug 2025 23:18:41 +0800
From: Tianyu Lan <ltykernel@...il.com>
To: Neeraj Upadhyay <Neeraj.Upadhyay@....com>
Cc: kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
decui@...rosoft.com, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com, arnd@...db.de,
kvijayab@....com, Tianyu Lan <tiala@...rosoft.com>, linux-arch@...r.kernel.org,
linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
Michael Kelley <mhklinux@...look.com>
Subject: Re: [RFC PATCH V5 2/4] Drivers: hv: Allow vmbus message synic
interrupt injected from Hyper-V
On Tue, Aug 5, 2025 at 9:59 PM Neeraj Upadhyay <Neeraj.Upadhyay@....com> wrote:
>
>
>
> On 8/4/2025 11:35 PM, Tianyu Lan wrote:
> > From: Tianyu Lan <tiala@...rosoft.com>
> >
> > diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> > index 308c8f279df8..2ff433cb5cc2 100644
> > --- a/drivers/hv/hv.c
> > +++ b/drivers/hv/hv.c
> > @@ -314,8 +314,11 @@ void hv_synic_enable_regs(unsigned int cpu)
> > shared_sint.vector = vmbus_interrupt;
> > shared_sint.masked = false;
> > shared_sint.auto_eoi = hv_recommend_using_aeoi();
> > +
>
> Nit: extra newline.
Thanks for your review. Will remove it..
>
> > hv_set_msr(HV_MSR_SINT0 + VMBUS_MESSAGE_SINT, shared_sint.as_uint64);
> >
> > + hv_enable_coco_interrupt(cpu, vmbus_interrupt, true);
> > +
> > /* Enable the global synic bit */
> > sctrl.as_uint64 = hv_get_msr(HV_MSR_SCONTROL);
> > sctrl.enable = 1;
> > @@ -342,7 +345,6 @@ void hv_synic_disable_regs(unsigned int cpu)
> > union hv_synic_scontrol sctrl;
> >
> > shared_sint.as_uint64 = hv_get_msr(HV_MSR_SINT0 + VMBUS_MESSAGE_SINT);
> > -
>
> Nit: extra newline.
>
Will remove it..
>
> > shared_sint.masked = 1;
> >
> > /* Need to correctly cleanup in the case of SMP!!! */
> > @@ -350,6 +352,9 @@ void hv_synic_disable_regs(unsigned int cpu)
> > hv_set_msr(HV_MSR_SINT0 + VMBUS_MESSAGE_SINT, shared_sint.as_uint64);
> >
> > simp.as_uint64 = hv_get_msr(HV_MSR_SIMP);
> > +
> > + hv_enable_coco_interrupt(cpu, vmbus_interrupt, false);
> > +
>
> Nit: Maybe this should be above "simp.as_uint64 = hv_get_msr(HV_MSR_SIMP)" ?
>
--
Thanks
Tianyu Lan
Powered by blists - more mailing lists