linux-kernel - Re: [PATCH v12 3/3] clk: aspeed: add AST2700 clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e53edafb-bfb0-45ab-8224-7b393af4e0ad@lunn.ch>
Date: Wed, 6 Aug 2025 05:03:25 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Mo Elbadry <elbadrym@...gle.com>
Cc: Ryan Chen <ryan_chen@...eedtech.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Joel Stanley <joel@....id.au>,
	Andrew Jeffery <andrew@...econstruct.com.au>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	"linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Rom Lemarchand <romlem@...gle.com>,
	William Kennington <wak@...gle.com>,
	Yuxiao Zhang <yuxiaozhang@...gle.com>,
	"wthai@...dia.com" <wthai@...dia.com>,
	"leohu@...dia.com" <leohu@...dia.com>,
	"dkodihalli@...dia.com" <dkodihalli@...dia.com>,
	"spuranik@...dia.com" <spuranik@...dia.com>
Subject: Re: [PATCH v12 3/3] clk: aspeed: add AST2700 clock driver

> > > +static const struct clk_div_table ast2700_rgmii_div_table[] = {
> > > +     { 0x0, 4 },
> > > +     { 0x1, 4 },
> > > +     { 0x2, 6 },
> > > +     { 0x3, 8 },
> > > +     { 0x4, 10 },
> > > +     { 0x5, 12 },
> > > +     { 0x6, 14 },
> > > +     { 0x7, 16 },
> > > +     { 0 }
> > > +};

> > > +     DIVIDER_CLK(SCU1_CLK_RGMII, "rgmii", soc1_hpll,
> > > +                 SCU1_CLK_SEL1, 25, 3, ast2700_rgmii_div_table),


Historically, aspeed has got RGMII delays wrong. Could you confirm
this has nothing to do with the 2ns delay needed by RGMII.

What exactly is this clock used for? RGMII needs 2.5MHz, 25MHz and
125MHz, which none of these dividers seems to provide.

	Andrew