linux-kernel - Re: [PATCH 2/2] vfs: output mount_too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250806054116.GE222315@ZenIV>
Date: Wed, 6 Aug 2025 06:41:16 +0100
From: Al Viro <viro@...iv.linux.org.uk>
To: Aleksa Sarai <cyphar@...har.com>
Cc: Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
	David Howells <dhowells@...hat.com>, linux-api@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 2/2] vfs: output mount_too_revealing() errors to fscontext

On Wed, Aug 06, 2025 at 02:48:30PM +1000, Aleksa Sarai wrote:

>  	error = security_sb_kern_mount(sb);
> -	if (!error && mount_too_revealing(sb, &mnt_flags))
> +	if (!error && mount_too_revealing(sb, &mnt_flags)) {
>  		error = -EPERM;
> +		errorfcp(fc, "VFS", "Mount too revealing");
> +	}

Hmm...  For aesthetics sake, I'd probably do logging first; otherwise
fine by me.