linux-kernel - Re: [PATCH 2/2] vfs: output mount_too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025-08-06.1754460368-noisy-refuge-smug-prawn-butch-motel-aC7jBh@cyphar.com>
Date: Wed, 6 Aug 2025 16:06:26 +1000
From: Aleksa Sarai <cyphar@...har.com>
To: Al Viro <viro@...iv.linux.org.uk>
Cc: Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>, 
	David Howells <dhowells@...hat.com>, linux-api@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 2/2] vfs: output mount_too_revealing() errors to fscontext

On 2025-08-06, Al Viro <viro@...iv.linux.org.uk> wrote:
> On Wed, Aug 06, 2025 at 02:48:30PM +1000, Aleksa Sarai wrote:
> 
> >  	error = security_sb_kern_mount(sb);
> > -	if (!error && mount_too_revealing(sb, &mnt_flags))
> > +	if (!error && mount_too_revealing(sb, &mnt_flags)) {
> >  		error = -EPERM;
> > +		errorfcp(fc, "VFS", "Mount too revealing");
> > +	}
> 
> Hmm...  For aesthetics sake, I'd probably do logging first; otherwise
> fine by me.

Good point, I'll send a v2.

-- 
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)