linux-kernel - [PATCH] cpupower: repair mangled powercap comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250806-mangled_cpupower-v1-1-1a559130326b@uniontech.com>
Date: Wed, 06 Aug 2025 15:08:02 +0800
From: Cryolitia PukNgae via B4 Relay <devnull+cryolitia.uniontech.com@...nel.org>
To: Thomas Renninger <trenn@...e.com>, Shuah Khan <shuah@...nel.org>, 
 "John B. Wyatt IV" <jwyatt@...hat.com>, John Kacur <jkacur@...hat.com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Wangyuli@...ontech.com, Guanwentao@...ontech.com, Zhanjun@...ontech.com, 
 Cryolitia PukNgae <cryolitia@...ontech.com>
Subject: [PATCH] cpupower: repair mangled powercap comment

From: Cryolitia PukNgae <cryolitia@...ontech.com>

The current comment exhibits clear patch application artifacts:
1. A stray '-' prefix indicating failed line removal
2. Broken sentence structure from improper context patching

What appears to be version control residue has persisted since its
initial introduction and through the 2022 kernel submission[1]. While
my archaeological efforts only trace back to the 2017 openSUSE patch[2],
the corrupted syntax suggests even older origins that remain elusive -
perhaps maintainers with longer institutional memory could shed light
on its provenance.

Restore grammatical sanity by:
- Removing the redundant second line with its leading '-'
- Preserving only the primary statement about RAPL hardcoding
- Eliminating the fragmented "should show up" clause

The result reflects reality without speculative future-proofing.

1. https://lore.kernel.org/all/20221123111810.16017-2-trenn@suse.de/
2. https://build.opensuse.org/request/show/535512

Signed-off-by: Cryolitia PukNgae <cryolitia@...ontech.com>
---
 tools/power/cpupower/lib/powercap.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/power/cpupower/lib/powercap.c b/tools/power/cpupower/lib/powercap.c
index 94a0c69e55ef5e4291b13a4218e706fa8d14e6a7..609943c829efce8045d97097b5f5e9ec86d0f519 100644
--- a/tools/power/cpupower/lib/powercap.c
+++ b/tools/power/cpupower/lib/powercap.c
@@ -87,8 +87,6 @@ int powercap_set_enabled(int mode)

 /*
  * Hardcoded, because rapl is the only powercap implementation
-- * this needs to get more generic if more powercap implementations
- * should show up
  */
 int powercap_get_driver(char *driver, int buflen)
 {

---
base-commit: 6bcdbd62bd56e6d7383f9e06d9d148935b3c9b73
change-id: 20250806-mangled_cpupower-5186789f8b2b

Best regards,
-- 
Cryolitia PukNgae <cryolitia@...ontech.com>