linux-kernel - Re: [PATCH] cpupower: repair mangled powercap comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b89a0377-2a1c-418f-a897-966cf1cd4789@linuxfoundation.org>
Date: Wed, 6 Aug 2025 17:37:35 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: cryolitia@...ontech.com, Thomas Renninger <trenn@...e.com>,
 Shuah Khan <shuah@...nel.org>, "John B. Wyatt IV" <jwyatt@...hat.com>,
 John Kacur <jkacur@...hat.com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 Wangyuli@...ontech.com, Guanwentao@...ontech.com, Zhanjun@...ontech.com,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] cpupower: repair mangled powercap comment

On 8/6/25 01:08, Cryolitia PukNgae via B4 Relay wrote:
> From: Cryolitia PukNgae <cryolitia@...ontech.com>
> 
> The current comment exhibits clear patch application artifacts:
> 1. A stray '-' prefix indicating failed line removal
> 2. Broken sentence structure from improper context patching
> 
> What appears to be version control residue has persisted since its
> initial introduction and through the 2022 kernel submission[1]. While
> my archaeological efforts only trace back to the 2017 openSUSE patch[2],
> the corrupted syntax suggests even older origins that remain elusive -
> perhaps maintainers with longer institutional memory could shed light
> on its provenance.
> 
> Restore grammatical sanity by:
> - Removing the redundant second line with its leading '-'
> - Preserving only the primary statement about RAPL hardcoding
> - Eliminating the fragmented "should show up" clause
> 
> The result reflects reality without speculative future-proofing.
> 
> 1. https://lore.kernel.org/all/20221123111810.16017-2-trenn@suse.de/
> 2. https://build.opensuse.org/request/show/535512

Lots of information for a simple comment spacing change.
What are we fixing here? What happens if we don't fix it?

thanks,
-- Shuah