linux-kernel - Re: [PATCH] cpupower: repair mangled powercap comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <09CBAB1CC89DA3CA+31b5524d-2781-4f0b-b544-0a833eaf3c8e@uniontech.com>
Date: Thu, 7 Aug 2025 11:47:00 +0800
From: Cryolitia PukNgae <cryolitia@...ontech.com>
To: Shuah Khan <skhan@...uxfoundation.org>, Thomas Renninger
 <trenn@...e.com>, Shuah Khan <shuah@...nel.org>,
 "John B. Wyatt IV" <jwyatt@...hat.com>, John Kacur <jkacur@...hat.com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 Wangyuli@...ontech.com, Guanwentao@...ontech.com, Zhanjun@...ontech.com
Subject: Re: [PATCH] cpupower: repair mangled powercap comment

On 07/08/2025 07.37, Shuah Khan wrote:
> On 8/6/25 01:08, Cryolitia PukNgae via B4 Relay wrote:
>> From: Cryolitia PukNgae <cryolitia@...ontech.com>
>>
>> The current comment exhibits clear patch application artifacts:
>> 1. A stray '-' prefix indicating failed line removal
>> 2. Broken sentence structure from improper context patching
>>
>> What appears to be version control residue has persisted since its
>> initial introduction and through the 2022 kernel submission[1]. While
>> my archaeological efforts only trace back to the 2017 openSUSE patch[2],
>> the corrupted syntax suggests even older origins that remain elusive -
>> perhaps maintainers with longer institutional memory could shed light
>> on its provenance.
>>
>> Restore grammatical sanity by:
>> - Removing the redundant second line with its leading '-'
>> - Preserving only the primary statement about RAPL hardcoding
>> - Eliminating the fragmented "should show up" clause
>>
>> The result reflects reality without speculative future-proofing.
>>
>> 1. https://lore.kernel.org/all/20221123111810.16017-2-trenn@suse.de/
>> 2. https://build.opensuse.org/request/show/535512
>
> Lots of information for a simple comment spacing change.

The critical issue is the leading '-' in the comment, not just spacing. This is almost certainly a patch application artifact - likely from a more earlier source than the 2017 openSUSE patch.

> What are we fixing here? What happens if we don't fix it?

Nothing happens. The kernel will run as usual, but cleaner than leaving version control artifacts confusing future readers.

>
> thanks,
> -- Shuah
>