[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aJKcSZCirArmH2/c@linux.gnuweeb.org>
Date: Wed, 6 Aug 2025 07:05:29 +0700
From: Ammar Faizi <ammarfaizi2@...weeb.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Simon Horman <horms@...nel.org>, Oliver Neukum <oneukum@...e.com>,
Andrew Lunn <andrew+netdev@...n.ch>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Linux Netdev Mailing List <netdev@...r.kernel.org>,
Linux USB Mailing List <linux-usb@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Armando Budianto <sprite@...weeb.org>, gwml@...r.gnuweeb.org,
stable@...r.kernel.org, John Ernberg <john.ernberg@...ia.se>
Subject: Re: [PATCH net v2] net: usbnet: Fix the wrong netif_carrier_on()
call placement
On Wed, Aug 06, 2025 at 06:56:20AM +0700, Ammar Faizi wrote:
> Apart from moving it outside that if-statement, unlink_urbs() call
> should probably also be guarded as we agreed it makes no sense to call
> it when we're turning the link on.
Oh, no.
I just realized, it does need to be guarded because if netif_carrier_on()
is placed before the if (!netif_carrier_ok(dev->net)), it already clears
__LINK_STATE_NOCARRIER.
--
Ammar Faizi
Powered by blists - more mailing lists