linux-kernel - Re: [PATCH v2] usb: misc: eud: Remove error print for devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5bgmxatzdgkxvuko56siujzlokyie5ru53rgozxrdaey6awmqy@u5pzyrfc7ve3>
Date: Tue, 5 Aug 2025 18:48:07 -0700
From: Bjorn Andersson <andersson@...nel.org>
To: Waqar Hameed <waqar.hameed@...s.com>
Cc: Souradeep Chowdhury <quic_schowdhu@...cinc.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, kernel@...s.com, linux-arm-msm@...r.kernel.org, 
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] usb: misc: eud: Remove error print for
 devm_add_action_or_reset()

On Tue, Aug 05, 2025 at 11:33:37AM +0200, Waqar Hameed wrote:
> When `devm_add_action_or_reset()` fails, it is due to a failed memory
> allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do
> anything when error is `-ENOMEM`. Therefore, remove the useless call to
> `dev_err_probe()` when `devm_add_action_or_reset()` fails, and just
> return the value instead.
> 
> Signed-off-by: Waqar Hameed <waqar.hameed@...s.com>

Reviewed-by: Bjorn Andersson <andersson@...nel.org>

Regards,
Bjorn

> ---
> Changes in v2:
> 
> * Split the patch to one seperate patch for each sub-system.
> 
> Link to v1: https://lore.kernel.org/all/pnd7c0s6ji2.fsf@axis.com/
> 
>  drivers/usb/misc/qcom_eud.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/misc/qcom_eud.c b/drivers/usb/misc/qcom_eud.c
> index 83079c414b4f..67832790acad 100644
> --- a/drivers/usb/misc/qcom_eud.c
> +++ b/drivers/usb/misc/qcom_eud.c
> @@ -193,8 +193,7 @@ static int eud_probe(struct platform_device *pdev)
>  
>  	ret = devm_add_action_or_reset(chip->dev, eud_role_switch_release, chip);
>  	if (ret)
> -		return dev_err_probe(chip->dev, ret,
> -				"failed to add role switch release action\n");
> +		return ret;
>  
>  	chip->base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(chip->base))
> 
> base-commit: 260f6f4fda93c8485c8037865c941b42b9cba5d2
> -- 
> 2.39.5
>