linux-kernel - [PATCH] acpi: Use swap() to simplify code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250806123821.381002-1-liaoyuanhong@vivo.com>
Date: Wed,  6 Aug 2025 20:38:20 +0800
From: Liao Yuanhong <liaoyuanhong@...o.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>,
	Robert Moore <robert.moore@...el.com>,
	Len Brown <lenb@...nel.org>,
	linux-acpi@...r.kernel.org (open list:ACPI COMPONENT ARCHITECTURE (ACPICA)),
	acpica-devel@...ts.linux.dev (open list:ACPI COMPONENT ARCHITECTURE (ACPICA)),
	linux-kernel@...r.kernel.org (open list)
Cc: liaoyuanhong@...o.com
Subject: [PATCH] acpi: Use swap() to simplify code

Replace the original swapping logic with swap() to improve readability and
remove temporary variables

Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
---
 drivers/acpi/acpica/nsrepair2.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/acpi/acpica/nsrepair2.c b/drivers/acpi/acpica/nsrepair2.c
index 8dbb870f40d2..e3df5968165b 100644
--- a/drivers/acpi/acpica/nsrepair2.c
+++ b/drivers/acpi/acpica/nsrepair2.c
@@ -875,7 +875,6 @@ acpi_ns_sort_list(union acpi_operand_object **elements,
 {
 	union acpi_operand_object *obj_desc1;
 	union acpi_operand_object *obj_desc2;
-	union acpi_operand_object *temp_obj;
 	u32 i;
 	u32 j;
 
@@ -891,11 +890,8 @@ acpi_ns_sort_list(union acpi_operand_object **elements,
 			      obj_desc2->integer.value))
 			    || ((sort_direction == ACPI_SORT_DESCENDING)
 				&& (obj_desc1->integer.value <
-				    obj_desc2->integer.value))) {
-				temp_obj = elements[j - 1];
-				elements[j - 1] = elements[j];
-				elements[j] = temp_obj;
-			}
+				    obj_desc2->integer.value)))
+				swap(elements[j], elements[j - 1]);
 		}
 	}
 }
-- 
2.34.1