linux-kernel - Re: [PATCH] acpi: Use swap() to simplify code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hhVBEvFq6ggxbV421J_+w+d7bhbaJ=15W9oLvEDiXpsg@mail.gmail.com>
Date: Tue, 12 Aug 2025 15:12:32 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Liao Yuanhong <liaoyuanhong@...o.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Robert Moore <robert.moore@...el.com>, 
	Len Brown <lenb@...nel.org>, 
	"open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" <linux-acpi@...r.kernel.org>, 
	"open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" <acpica-devel@...ts.linux.dev>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] acpi: Use swap() to simplify code

On Wed, Aug 6, 2025 at 2:38 PM Liao Yuanhong <liaoyuanhong@...o.com> wrote:
>
> Replace the original swapping logic with swap() to improve readability and
> remove temporary variables
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
> ---
>  drivers/acpi/acpica/nsrepair2.c | 8 ++------

ACPICA changes need to be submitted as pull requests to the upstream
ACPICA project on GitHub.  Corresponding Linux patches can only be
applied after those changes have been accepted upstream (and those
patches need to point to the corresponding upstream ACPICA commits via
Link: tags).

Thanks!

>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/acpi/acpica/nsrepair2.c b/drivers/acpi/acpica/nsrepair2.c
> index 8dbb870f40d2..e3df5968165b 100644
> --- a/drivers/acpi/acpica/nsrepair2.c
> +++ b/drivers/acpi/acpica/nsrepair2.c
> @@ -875,7 +875,6 @@ acpi_ns_sort_list(union acpi_operand_object **elements,
>  {
>         union acpi_operand_object *obj_desc1;
>         union acpi_operand_object *obj_desc2;
> -       union acpi_operand_object *temp_obj;
>         u32 i;
>         u32 j;
>
> @@ -891,11 +890,8 @@ acpi_ns_sort_list(union acpi_operand_object **elements,
>                               obj_desc2->integer.value))
>                             || ((sort_direction == ACPI_SORT_DESCENDING)
>                                 && (obj_desc1->integer.value <
> -                                   obj_desc2->integer.value))) {
> -                               temp_obj = elements[j - 1];
> -                               elements[j - 1] = elements[j];
> -                               elements[j] = temp_obj;
> -                       }
> +                                   obj_desc2->integer.value)))
> +                               swap(elements[j], elements[j - 1]);
>                 }
>         }
>  }
> --
> 2.34.1
>
>