linux-kernel - Re: [PATCH v2] scsi: ufs: core: Remove error print for devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1sei59o0y.fsf@ca-mkp.ca.oracle.com>
Date: Tue, 05 Aug 2025 22:34:17 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Waqar Hameed <waqar.hameed@...s.com>
Cc: Alim Akhtar <alim.akhtar@...sung.com>, Avri Altman
 <avri.altman@....com>,
        Bart Van Assche <bvanassche@....org>,
        "James E.J.
 Bottomley" <James.Bottomley@...senPartnership.com>,
        "Martin K. Petersen"
 <martin.petersen@...cle.com>, <kernel@...s.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] scsi: ufs: core: Remove error print for
 devm_add_action_or_reset()


Waqar,

> When `devm_add_action_or_reset()` fails, it is due to a failed memory
> allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't
> do anything when error is `-ENOMEM`. Therefore, remove the useless
> call to `dev_err_probe()` when `devm_add_action_or_reset()` fails, and
> just return the value instead.

Applied to 6.17/scsi-staging, thanks!

-- 
Martin K. Petersen