lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAHp75VcD8nKdcEvQDnASfhF3a1VK71wjk55TeX6kJSC2UQQZoQ@mail.gmail.com>
Date: Thu, 7 Aug 2025 22:36:13 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: David Lechner <dlechner@...libre.com>
Cc: Salah Triki <salah.triki@...il.com>, Jonathan Cameron <jic23@...nel.org>, 
	Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: pressure: bmp280: Use IS_ERR_OR_NULL() in bmp280_common_probe()

On Thu, Aug 7, 2025 at 3:24 AM David Lechner <dlechner@...libre.com> wrote:
> On 8/6/25 7:52 PM, Salah Triki wrote:

...

All what David said I agree with.

> Also, gpiod_set_value_cansleep() would be more
> appropriate. This is not an atomic context.

Just note that the original code doesn't have it, so it may be done in
a separate patch.

-- 
With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ