linux-kernel - Re: [PATCH] iio: adc: ad9467: Replace PTR_ERR_OR_ZERO() in ad9467

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vfe2A6ZSxLO5GLPnEEQzRnaLkxNXLf2bNpoWeO8pL0ejg@mail.gmail.com>
Date: Thu, 7 Aug 2025 22:38:01 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Salah Triki <salah.triki@...il.com>
Cc: Michael Hennerich <Michael.Hennerich@...log.com>, Nuno Sa <nuno.sa@...log.com>, 
	Lars-Peter Clausen <lars@...afoo.de>, Jonathan Cameron <jic23@...nel.org>, 
	David Lechner <dlechner@...libre.com>, Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ad9467: Replace PTR_ERR_OR_ZERO() in ad9467_reset()

On Thu, Aug 7, 2025 at 3:39 AM Salah Triki <salah.triki@...il.com> wrote:
>
> PTR_ERR_OR_ZERO() returns 0 if the argument is NULL, which can hide real
> issues when the caller expects an ERR_PTR on failure. Use a ternary

ERR_PTR()

> expression instead to return the appropriate error code.

Tell us more how you got all this, please. (A new) static analyser
tool? Reading the code?

-- 
With Best Regards,
Andy Shevchenko