[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAHp75VeRDme0daA_P7nQu1RXVUry_6TKoW1P3xX+-BqDAk6K-A@mail.gmail.com>
Date: Thu, 7 Aug 2025 23:23:11 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Salah Triki <salah.triki@...il.com>
Cc: Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>,
Nuno Sá <nuno.sa@...log.com>,
Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: pressure: bmp280: Use IS_ERR() in bmp280_common_probe()
On Thu, Aug 7, 2025 at 4:25 AM Salah Triki <salah.triki@...il.com> wrote:
>
> `devm_gpiod_get_optional()` may return non-NULL error pointer on failure.
> Check its return value using `IS_ERR()` and propagate the error if
> necessary.
> `dev_info()` has been dropped as it was considered noisy.
> Also switch to `gpiod_set_value_cansleep()`, which is safe to use in
> sleepable contexts like probe.
'Also' automatically means: Please split to a separate patch.
You may drop dev_info() in the patch which converts to _cansleep,
though. Ordering of the patch should be based on the least noise and
churn between them.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists